#qa | Logs for 2017-02-02

« return
[15:58:29] <Bytram> just came here from a discussion with TheMightyBuzzard on some bugs found in new comment layout code.
[15:59:03] <TheMightyBuzzard> yes, that's not a bug. that's the result of the bug i fixed.
[15:59:33] <TheMightyBuzzard> the comments were going in to the db as top level comments not replies. you'd have to hand fix them now.
[15:59:42] <Bytram> which one is not a bug?+
[16:00:07] <TheMightyBuzzard> the indentation
[16:00:28] <TheMightyBuzzard> they're not indented because they're not replies as far as rehash is concerned
[16:01:16] <Bytram> ummm, #30896 is a *reply* to #30895, but is not indented and does not present parent button, even though I selected Threaded
[16:01:38] <Bytram> and... #30898 is a reply to #30897
[16:01:51] <Bytram> woops
[16:02:27] <Bytram> #30897 is a reply to #30896 which, in turn, is a reply to #30895
[16:04:53] <TheMightyBuzzard> checking a fix for comment links real quick
[16:05:40] <Bytram> nod nod
[16:05:41] <TheMightyBuzzard> see above. all the comments that are not indented HAVE NO parents because they were not entered into the db as replies.
[16:06:19] <Bytram> hmmm, so even though, using the UI, I entered them as replies, there was a bug that saved them as top-level comments... is that right?
[16:06:42] <TheMightyBuzzard> yes
[16:06:57] <TheMightyBuzzard> damn, my fix didn't
[16:07:13] <Bytram> ahhh, that makes more sense... I now realize you said that earlier, but it didn't register at the time -- my apologies
[16:09:48] * TheMightyBuzzard grumbles at his brain
[16:10:05] * Bytram is making new test data
[16:11:45] <Bytram> at first glance, is looking better
[16:12:57] <Bytram> parent button does not seem to include cid; see: https://dev.soylentnews.org
[16:13:00] <exec> └─ 13Dev.SN Comments | 20170202a - test story for submtting indented comments
[16:14:59] <TheMightyBuzzard> deploying another potential fix.
[16:15:28] <TheMightyBuzzard> ugh, crap
[16:15:47] <TheMightyBuzzard> my templating fixes did not
[16:16:06] <TheMightyBuzzard> this is ALL from hardcoding templates
[16:16:13] <Bytram> nod nod
[16:16:41] <TheMightyBuzzard> da fuq?
[16:16:54] <Bytram> I had gathered that since everything was basically made explicit, was gonna need a test case for every single variation... hence my automation efforts which are not QUITE far enough along. :(
[16:19:05] -!- saxdm [saxdm!~wally@207.87.iy.nnl] has joined #qa
[16:19:20] -!- saxdm [saxdm!~wally@207.87.iy.nnl] has parted #qa
[16:19:30] <Bytram> the "Reply to This" button seems to be working okay, so far.
[16:19:34] <TheMightyBuzzard> automations are fine. it's the templating that's fucking me up now. tons of it simply do not work.
[16:19:48] <TheMightyBuzzard> hit a comment #cid link
[16:19:56] <TheMightyBuzzard> shows the comment text as "1"
[16:19:56] <Bytram> urgh. so sorry to hear that!
[16:20:15] <Bytram> here's a bit smaller set of sample data to play with: https://dev.soylentnews.org
[16:20:18] <exec> └─ 1320170202a - test story for submtting indented comments - Dev.SN
[16:20:33] <Bytram> besides the other test stories I'd already submitted. =)
[16:20:44] <TheMightyBuzzard> oh, i know why
[16:21:06] <TheMightyBuzzard> can't play yet, chasing a bug
[16:21:55] <Bytram> I'm gonna need to take a break -- have an appt this pm and need to get prepared... keep me posted here and I'll check back in in a bit -- have a wonky internet connection so am leaving irc for the time being, but will check back in as soon as I can -- prolly at least 45 minutes or an hour
[16:22:08] <Bytram> teamwork++
[16:22:41] <Bytram> teamwork++
[16:23:07] <Bytram> oh well! laters
[16:25:24] <TheMightyBuzzard> yarp
[16:28:21] <TheMightyBuzzard> okay, i THINK it's all working now. if you can find more bugs, specially in templating, have at it.
[16:56:17] <TheMightyBuzzard> fixing the Parent links now
[16:57:33] <TheMightyBuzzard> parent links fixed
[17:04:28] <TheMightyBuzzard> hrm, moderation summary isn't showing up if you're an admin on dev
[17:52:14] <Bytram> just logged out of dev (was martyb) and logged back in as bytram ... loaded: https://dev.soylentnews.org (which defaults to: thresh: -1 and break: -1, viewing as threaded and oldest first)
[17:52:17] <Bytram> two things
[17:52:17] <exec> └─ 1320170202a - test story for submtting indented comments - Dev.SN
[17:52:25] <TheMightyBuzzard> sup?
[17:52:30] <Bytram> (1) still seeing extra drop down choices in sort field
[17:52:44] <TheMightyBuzzard> yes, still haven't fixed those
[17:53:06] <Bytram> (2) of the 9 comments, currently, do not see moderation drop down on comments: #30917 and #30918
[17:54:08] <TheMightyBuzzard> can't mod your own comments, so you don't get a box on them
[17:55:03] <Bytram> I thought of that, but comments were submited as martyb and I am now bytram; also I see moderation drop down on ALL comments EXCEPT just those two.
[17:55:36] <Bytram> I would think that I should be able to mod ALL of the comments
[17:55:37] <TheMightyBuzzard> ipid
[17:55:52] <TheMightyBuzzard> you can't moderate comments that came from the same ipid either
[17:56:28] <Bytram> hmmm, oh. I did have some connection hiccups... these are the two most recent comments; that prolly splains it
[17:56:39] <TheMightyBuzzard> all the others were posted from one ipid and then those two are from the one you're on now.
[17:56:41] <Bytram> hmm
[17:56:43] <Bytram> brb
[17:57:27] <Bytram> back
[17:57:56] <TheMightyBuzzard> whatzit say now?
[17:58:20] <Bytram> didn't that would work and was not surpised... I disconnected my PC from my phone and then reconnected, but seeing same as before
[17:58:34] <Bytram> will try airplane mode -- that should do it.
[17:58:35] <Bytram> brb
[17:58:38] <TheMightyBuzzard> well um yeah
[17:58:46] <TheMightyBuzzard> you'd need to reboot your phone
[17:59:06] -!- mrpg [mrpg!~Thunderbi@Soylent/Staff/Editor/mrpg] has joined #qa
[17:59:38] <TheMightyBuzzard> grabbin a smoke since i'm almost certain there's no bug there.
[18:02:03] <mrpg> good.
[18:02:45] <Bytram> well, this is too weird -- now the ONLY two comments where I can moderate are the ones that I could not moderate before: #30917 and #30918
[18:03:19] <Bytram> am posting a TLC (Top Level Comment) as bytram ondev
[18:04:04] <mrpg> I was thinking that the "quote this" option is not on slash, but only in takyon's script, am I right?
[18:04:10] <Bytram> correct
[18:04:23] <mrpg> ahhh, so I didnt' find a bug :-(
[18:04:46] <Bytram> I do a drag select, copy, and then in the comment entry field enter: <blockquote> [paste] </blockquote>
[18:05:57] <Bytram> just posted as bytram: TLC: #30919 and reply to that TLC: #30920
[18:07:32] <Bytram> as user bytram, I see: #30912 having score 2 (posted as martyb), #30914 having score 0 (posted as marty but ANONYMOUSLY), and #30919 having score 1 (posted as bytram) -- with no moderations performed on any of those comments.
[18:08:15] <Bytram> okay, really go to get ready for an appointment this pm; won't be back for a couple hours, at least, at the earliest.
[18:15:26] <TheMightyBuzzard> yep, i'm out for the afternoon myself
[19:20:02] -!- mrpg [mrpg!~Thunderbi@Soylent/Staff/Editor/mrpg] has parted #qa