#dev | Logs for 2020-03-23

« return
[12:01:10] * Bytram notices an oversight in his "Skip to comments(s)" addition; Roughly, the page that gets displayed when someone clicks on the "n" in "You have n [un]|read messages" on the main page, the resulting page, (1) displays right at the top of the story (should use a fragment ID to position then at the comment, and (2) the story title bar is missing the "Skip to comment(s)]" link
[12:02:12] <Bytram> cf: https://soylentnews.org
[12:02:12] <systemd> ^ 03SoylentNews Message Center
[12:02:39] <Bytram> and, for an actual example I am looking at now: https://soylentnews.org
[12:02:39] <systemd> ^ 03SoylentNews Comments | Changing Site UI to Make Long Stories Easier to Navigate -- Input Requested [superseded; see update]
[12:03:30] <Bytram> So, to my eye, it looks like comments.pl may need some work? Or whatever invokes it needs to add the fragid.
[12:03:52] <TheMightyBuzzard> Bytram, you also used the wrong anchor. should have gone with #commentwrap or #commentlisting instead of making a new one.
[12:07:06] * Bytram DID NOT MAKE A NEW ONE... used what was already there.
[12:07:36] <TheMightyBuzzard> ah, okey doke
[12:07:38] * Bytram may not have made best choice, but seemed to get me towards where I wanted to go.
[12:07:56] <TheMightyBuzzard> thought that was a new one. no worries then.
[12:10:12] * Bytram just tried a quick hack/test... #commentwrap is much better than #acomments...
[12:10:58] * Bytram just tried a quick hack/test... #commentwrap is much better than #acomments...
[12:11:05] * Bytram tries: https://soylentnews.org
[12:12:28] <TheMightyBuzzard> one gets you the controls, the other gets you the actual comments.
[12:12:33] <Bytram> nod nod
[12:12:58] * Bytram needs to *see* it to make it clear in my mind what does what... got it, now, thanks!
[12:13:45] <TheMightyBuzzard> s'why i picked those two as examples
[12:17:19] <Bytram> gnawed gnawed
[12:18:30] <Bytram> I've been traipsing through the source perl and templates, and am struggling to find out where I need to add a "[Skip to comment(s)]" in the story header of when I go to read a reply to a message I've been sent.
[12:21:03] <TheMightyBuzzard> don't axe me, not enough coffee in me yet. off hand i'd guess printCommentsMain as a place to start backtracking
[12:23:24] * Bytram opens https://soylentnews.org and sees: (better still, when I see a link to "Anonymous Cowards has posted a comment, <a href="$href1"><b>$commenttitle1</b></a>, in reply to your comment, <a href="$href2"><b>$commenttitle2</b></a>, attached to story <a href="$href3"><b>$storytitle</b></a>
[12:25:38] <Bytram> (1) $href1 should, ideally, *contain* a #commentwrap (or the template that references it should append the "#commentwrap" fragid, (2) the resulting page (https://soylentnews.org/comments.pl?sid=36659&cid=974287) needs the "[Skip to comment(s)]" link addded.
[12:25:39] <systemd> ^ 03SoylentNews Comments | Changing Site UI to Make Long Stories Easier to Navigate -- Input Requested [superseded; see update]
[12:26:06] <TheMightyBuzzard> oh, you mean changing the links in the messages? don't.
[12:29:51] <Bytram> Umm, why? not being combative, just genuinely curious.
[12:29:55] <Bytram> Either way, that still leaves fixing the page generated by comments.pl so that it includes STC
[12:30:25] <Bytram> Oy! My connection just dropped, and reconnected TWICE in the past minute.
[12:30:37] <Bytram> brk time; biab
[12:41:02] <TheMightyBuzzard> Bytram, mostly because adding functionality without sanity checking yourself with staff isn't a big deal but changing functionality without some folks playing devil's advocate is.
[15:26:11] <Bytram> TheMightyBuzzard: Ah, got it. I agree
[15:26:22] <Bytram> Like what I do for you, eh?
[15:26:26] <Bytram> =)
[15:26:53] <janrinok> TheMightyBuzzard, welcome back!
[15:28:04] <Bytram> So, thinking out loud... given that the corona virus is going to be with us for a long while, and stuffing them into the main story queue would overwhelm all the other stories, and periodic round-up posts are labor-intensive... how hard would it be to create a new nexus for them?
[15:28:15] <TheMightyBuzzard> janrinok, grassy ass. got no idea how nice it is to sleep in my own bed.
[15:28:33] <TheMightyBuzzard> Bytram, eh, moderate pain.
[15:29:41] <Bytram> sleep++ is a very good thing!
[15:29:41] <Bender> karma - sleep: 1
[15:30:54] <TheMightyBuzzard> oh, looks like i done made a script to add one. i'll test it on dev later today.
[15:31:37] <TheMightyBuzzard> afk a few hours. stuff to do.
[15:32:12] <Bytram> Noice! Laters; and so good to have you back!
[15:42:47] -!- cosurgi has quit [Ping timeout: 244 seconds]
[22:06:40] <Bytram> TheMightyBuzzard: I am pretty sure I found it!
[22:06:54] <Bytram> in template: default;index;data
[22:07:31] <Bytram> Line 61, where it currently has:
[22:07:41] <Bytram> <a href="[% cc.1.0 | strip_attribute %]"[% IF cc.1.2 %] title="[% cc.1.2 | strip_attribute %]"[% END %]>[% cc.1.1 | strip_html %]</a> comment[% cc.3 != 1 ? 's' : '' %]
[22:07:46] <Bytram> change it to be:
[22:08:02] <Bytram> <a href="[% cc.1.0 | strip_attribute %]"[% IF cc.1.2 %] title="[% cc.1.2 | strip_attribute %]"[% END %]>[% cc.1.1 | strip_html %] comment[% cc.3 != 1 ? 's' : '' %]</a>
[22:08:48] <Bytram> THAT Should, replace "_3_ comments" with: "_3 comments_" on the main page.
[22:09:08] <Bytram> Is active on dev ATM as an in-memory change to the template
[22:10:09] <Bytram> I see NO side effects on a page with a single story.
[22:10:16] <TheMightyBuzzard> Bytram, we weren't talking about that but if you really feel the need
[22:10:56] <Bytram> Works on a journal page, too: https://dev.soylentnews.org
[22:10:58] <systemd> ^ 03Journal of Bytram (4031)
[22:11:03] <TheMightyBuzzard> if you're not keeping track of the hot changes, they're all going to get overwritten next proper update though.
[22:11:27] <Bytram> I am well aware... that is why I am documenting them here, as well as keeping local copies. =)
[22:12:02] <Bytram> I appreciate the cautions, though. Better to be told something one time too many than one time too few!
[22:12:07] <TheMightyBuzzard> yup
[22:20:39] <Bytram> It was surpringly easy to fix... once I found out where to do it. THAT was the tricky part.
[22:21:51] <TheMightyBuzzard> usually it tells you what template it's in if you look in the source. not as often as i'd like but usually.
[22:22:19] <TheMightyBuzzard> it's not really a fix though, being as it was working as intended
[22:22:41] <Bytram> IIRC there is/was a plugin where, instead of seeing just "100 comments", it would be displayed as: " 5, 12, 20, 45, 70, 90, 100 Comments" where each number corresponds to how many comments there are scored +5, +4, +3, +2, +1, 0, and -1, respectively.
[22:22:55] <Bytram> Oh, that's how I found it!
[22:23:56] <Bytram> I've got a local batch/awk program that scrapes a downloaded page, extracts the template begin/end messages, and outputs each (properly indented) along with the line number in which it was found. =)
[22:25:48] <Bytram> Oh, and I agree that, technically it is not a bug, but I would proffer that it is B.A.D. (Broken As Designed), insomuch my fine motor skills are not quite what they used to be, so having a large target to click on is a huge help.
[22:26:16] * Bytram should really spend about half a day getting a deep-tissue massage of his fore-arms.
[22:31:43] <TheMightyBuzzard> it's not even broken at all. it's just not going out of its way to be friendly to folks who can't see well
[22:34:17] <TheMightyBuzzard> not making accommodations to us folks whose peepers don't work quite like they used to may be annoying but it don't mean it's broke
[22:35:05] <TheMightyBuzzard> or them of us with huge hands/fingers who can't hardly hit the link on a phone without zooming way in
[22:35:12] * TheMightyBuzzard waves a huge hand
[22:50:40] <Bytram> I have a 43" TV as my monitor, driving it at 2200x1200 (the best my graphics processor can handle) and it is all too easy for me to grab an extra line by mistake... having to his just a single character to activate a link, when it could *easily* be made a larger target... WHY NOT do it?
[22:51:38] <Bytram> If the suggested change breaks something else, that would be one thing. But, if it works correctly this way, I fail to see any downside.
[22:52:25] <Bytram> Oh, and I have the same challenge on my smart phone, so i usually click the story title, all of which is an anchor, too.
[22:53:14] <Bytram> But, most people do not know that (because it is not underlined -- not easily discoverable). So, I am all for making the obvious as easy to use as possible.