#dev | Logs for 2018-10-16

« return
[12:29:10] <TheMightyBuzzard> FatPhil, you missed a ) in your regex on 1930
[12:32:10] <FatPhil> ooops
[12:32:49] <TheMightyBuzzard> think we need to add something to approved tags site var as well
[12:33:31] <TheMightyBuzzard> ya, type gets stripped out before it hits the db
[12:34:29] <TheMightyBuzzard> smoking then adding the var
[12:36:00] <FatPhil> in the open regexp?
[12:39:52] <FatPhil> qr[\n* <\s* $spoiler (?:\s+type=(["'])([^"']+)\1)? \s*> \n*]xsio
[12:40:20] <FatPhil> so several mistakes
[12:45:51] <FatPhil> does fixup patch fix it?
[12:52:23] <TheMightyBuzzard> FatPhil, dunno. gotta add type to the spoiler bit of the site var first.
[12:54:11] <FatPhil> does it at least parse?!
[12:54:22] <FatPhil> I fuckin' hate perl
[12:58:06] <TheMightyBuzzard> dunno. git got fucked up somehow
[13:03:58] <TheMightyBuzzard> it looks like it should at least
[13:06:45] <TheMightyBuzzard> FatPhil, looks like it works now. https://dev.soylentnews.org
[13:06:50] <exec> └─ 13spoiler testing - Dev.SN
[13:08:31] * TheMightyBuzzard scratches his chin
[13:11:28] <TheMightyBuzzard> FatPhil, add a comment above 1929 along the lines of "# spoiler:type needs to be added to approvedtags_attr in the vars table for spoilers to work"
[13:11:37] <TheMightyBuzzard> if you would, please
[13:28:17] <TheMightyBuzzard> FatPhil, nevermind. i can change it myself looks like.
[13:31:04] <TheMightyBuzzard> FatPhil, comment added and merged into master
[14:35:32] -!- sirecote [sirecote!sirecote@cpl.digitalhosting.ca] has joined #dev
[15:50:31] <FatPhil> ITYM: https://dev.soylentnews.org ;-)
[15:50:35] <exec> └─ 13spoiler testing - Dev.SN
[15:58:55] <FatPhil> Mind if I throw some fuzz tests at that story? First we build it, then we try to break it...
[16:07:30] <FatPhil> seems pretty stable
[16:35:02] -!- MrPlow has quit [Remote host closed the connection]
[16:36:02] -!- MrPlow [MrPlow!MrPlow@Soylent/BotArmy] has joined #dev
[16:36:03] -!- MrPlow has quit [Changing host]
[16:36:03] -!- MrPlow [MrPlow!MrPlow@nsa.gov] has joined #dev