#dev | Logs for 2017-04-27

« return
[00:05:55] <Bytram> paulej72: TheMightyBuzzard: umm, before we push the new stuff onto prod, I'd like to see a release summary to make sure I've had a chance to poke at everything... when I give the all-clear then go for it, or if you prefer, we can do several days of meta stories asking about what is still broken. ;)
[00:06:12] <Bytram> biab dishes
[01:30:56] <TheMightyBuzzard> Bytram, aside from stripe payments and uninstall of plugins, there's nothing in there but minor bug fixes.
[01:31:58] <Bytram> good to know. mind sharing with me the places where you found you needed to update things to handle "+" in nicks? Not so much places in the code, but places where I'd see it appear in the UI
[01:33:27] <TheMightyBuzzard> everywhere a nick is made into a link. there's about 60 different places.
[01:34:04] <Bytram> that's not terribly helpful, yanno?
[01:34:38] <TheMightyBuzzard> https://github.com
[01:34:40] <chromas> Does it just replace the + with a %20?
[01:34:46] <chromas> %2b
[01:34:57] <Bytram> you know me, I'm a details kind of guy... mind sharing a [half] dozen of 'em so i can get a feel for what I'm looking for here?
[01:35:05] <TheMightyBuzzard> yup, in the proper order though cause spaces get replaced with a +
[01:35:05] <Bytram> or NOT %2b?
[01:35:31] <Bytram> IOW: f(g(x)) != g(f(x))
[01:35:43] <chromas> What does a %20 get replaced with? :)
[01:35:56] <TheMightyBuzzard> nothin, % ain't valid in nicks.
[01:36:01] <chromas> gasp
[01:37:21] <TheMightyBuzzard> Bytram, i have no idea where all nicks show up linked any more than any other user does. i fixed the code, everywhere and checked in comments to see if it linked properly.
[01:38:19] <TheMightyBuzzard> don't have to understand WHY or WHERE it's wanting to display a link, just what the wrong code is going to look like to do so.
[01:38:24] <Bytram> gnawed. gnawed.
[01:39:01] <TheMightyBuzzard> stories, journals, comments... s'all i can think of offhand.
[01:39:23] <Bytram> yeah, I figured as much... was just hoping I wouldn't have to basically reverse-engineer everyplace by myself when you'd already gone through, and presumably verified, each place where you made a change... otoh
[01:39:41] <Bytram> otoh, that means with an independent assemssment, there's a chacnce I'll find a place that was not on your list
[01:39:59] <Bytram> on the groipping hand, i may miss a place that got fixed wrong.
[01:40:01] <Bytram> =)
[01:40:15] <Bytram> guess I better do a good job of it, then.
[01:40:34] * Bytram wishes his VM did not blow up on him. woulda been nice to be able to grep -R through the source
[01:40:44] <TheMightyBuzzard> there's roughly 66 different places it's gonna show up.
[01:40:53] <Bytram> ima not gonna dive into it this PM... too tired. Hope to maybe get a stab at it tomorrow.
[01:41:02] <TheMightyBuzzard> you're limited bandwidth, yeah?
[01:41:18] <Bytram> that helps -- gives me an idea of the order of magnitude of what I'm looking for. Had NO idea there were that many places.
[01:41:18] <Bytram> yep
[01:41:28] <Bytram> is better, now, but still limited.
[01:41:42] <Bytram> at best, I've seen about 700kBs
[01:41:57] <Bytram> and, have a cap of 6 gB/monthh
[01:42:09] <Bytram> unless I head on over to the library or the like
[01:42:16] * TheMightyBuzzard checks his vm size
[01:42:49] <TheMightyBuzzard> nope, wouldn't fit on a dvd-r
[01:43:17] * Bytram really apprecaiates the thought!
[01:43:42] <Bytram> and., with that, I need tohit the hay early. haven't got a full night's sleep in 3-4 days
[01:43:54] <Bytram> nice chatting with ya!
[01:43:59] <Bytram> ~gnight TheMightyBuzzard
[01:44:05] <TheMightyBuzzard> nite
[02:08:51] <paulej72> bytram: This PR allows for plugins to be coded for uninstall.
[02:08:51] <paulej72> So far only AJAX, Edit and Remarks have been coded for uninstall. These plugins were in the default install and are broken due to missing JS. Other plugins needed to be recoded to remove unsafe calls to these modules. These modules are set currently to not install their pm files as I have removed their Makefiles. This code is basically deprecated. Once they have been full tested for safe removal, we can kill off all of the code expect
[02:08:51] <paulej72> the stuff needed for uninstall.
[02:10:34] <paulej72> Also there is a manual cleanup script that we can put in cleanup code for when we delete plugins and want to clean up the stuff that gets installed: rehash/bin/cleanup-old
[02:10:52] <paulej72> Fix takyon’s user page by setting max submissions to view to 250.
[02:10:53] <paulej72> change logic so that noupdate logic will trigger when cid is set as well.
[02:10:53] <paulej72> made some cosmetic changes to DB upgrade files.
[02:10:53] <paulej72> revved the version to 17_05.
[02:12:29] <paulej72> AJAX, Edit and Remarks were uninstalled on dev and the cleanup script ran to remove the unneeded PM files
[11:40:35] -!- SoyGuest66489 has quit [Ping timeout: 276 seconds]
[11:44:32] -!- FatPhil [FatPhil!phil@azdr.ee] has joined #dev
[11:45:32] FatPhil is now known as SoyGuest48501
[12:09:17] <Bytram> paulej72: THANK-YOU!! (NOTE TO SELF: refer here to release notes)
[20:03:50] SoyGuest48501 is now known as FatPhil
[20:04:02] -!- FatPhil has quit [Changing host]
[20:04:02] -!- FatPhil [FatPhil!phil@Soylent/Staff/Editor/FatPhil] has joined #dev