#dev | Logs for 2017-03-14

« return
[01:28:52] <paulej72> fixed issue with @xx: eating a space
[01:29:02] <paulej72> actually any char
[01:29:12] <paulej72> but I put it back
[01:30:19] <Bytram> paulej72: nod nod, thanks... btw, ISTR the @xx: bug was a side effect of being able to refer to a nick in a comment which was a feature that TMB added a couple site releases ago.
[01:30:45] <paulej72> yeah, found it and fixed it
[01:30:57] <Bytram> also, is that fixed in the repo, on dev, and/or on prod?
[01:31:29] <paulej72> fixed on dev and in my current pull request
[01:31:35] <Bytram> nice!
[01:31:50] <paulej72> shit found a bug
[01:32:08] <Bytram> paulej72: many thanks for all the coding/debuggin you've put in over the past several weeks... I verymuch appreciate it.
[01:32:15] <paulej72> no way to add blank lines in plain text in a comment
[01:32:24] <Bytram> ruh roh!
[01:55:04] <paulej72> Never mind, it is OK I just could not see what was happening
[01:55:26] <Bytram> paulej72: Umm, i just tried twice to send myself an admin-to-user message and nothing appeared in my inbox. :/
[01:55:56] <cmn32480> what accoutn>
[01:56:43] <Bytram> msartyb
[01:56:52] <Bytram> martyb
[01:57:57] <Bytram> sry, my kbd is starting to get flakey on me
[01:57:58] * Bytram turns his kbd over and whacks out some crumbs
[01:58:39] <Bytram> paulej72: I just sent you an admin-to-user message
[01:59:06] <paulej72> on dev?
[01:59:11] <Bytram> yes
[02:00:16] <paulej72> looks fine now
[02:00:41] <Bytram> please send a message to me?
[02:00:48] <Bytram> martyb
[02:01:03] <Bytram> had just send you a 2nd message while you were checking.
[02:01:23] <paulej72> you can send a message to yourself
[02:01:45] <Bytram> yes, I am aware... and did that *twice* but have not received any message yet.
[02:01:50] <paulej72> https://dev.soylentnews.org
[02:02:01] <Bytram> yes, I am aware... and did that *twice* but have not received any message yet.
[02:02:05] <paulej72> check now I just ran message_deivery
[02:02:19] <paulej72> that url gets you to the list
[02:02:33] <paulej72> without having to delet one first
[02:02:38] <Bytram> i was looking at: https://dev.soylentnews.org
[02:02:55] <Bytram> which is the link on the LHS slashbox
[02:03:29] <Bytram> nope, nothing new
[02:04:08] <Bytram> btw, messagesa.pl is the one with the "checkbox view" -- I thought that was supposed to be gone?
[02:04:52] <Bytram> Also, https://dev.soylentnews.org is the link provided in the RHS slashbox which informs me that I have message(s)
[02:05:01] <paulej72> seems to be the default for that module
[02:05:32] <paulej72> Will need to look at how we do this
[02:06:00] <Bytram> k, many thanks!
[02:06:21] <paulej72> you should have serverl messages by this point
[02:06:31] <Bytram> this is on dev, right?
[02:06:52] <Bytram> still only see the two messages I had had before
[02:06:53] <paulej72> yes
[02:07:32] * Bytram checked BOTH messages.pl AND /my/inbox/
[02:09:54] <paulej72> you have admin to ueser messages as email
[02:10:16] <Bytram> huh? I don't remember EVER chagning that!
[02:10:18] <paulej72> check your email
[02:10:30] <Bytram> lol... and there they are.
[02:10:53] * Bytram goes off to chage his message setting back
[02:11:01] <Bytram> paulej72: so sorry to send you on a wild goose chase!
[02:12:30] <Bytram> I must have changed my setting to make sure that e-mail delivery worked, and then forgot to change it back.
[02:12:40] <Bytram> Doh!!
[04:29:08] Fnord666 is now known as peen_weinerstein
[04:29:53] peen_weinerstein is now known as Fnord666
[10:01:47] -!- anon9002 [anon9002!~anon@zn-329-828-58-09.revip63.asianet.co.th] has joined #dev
[10:18:30] -!- anon9002 has quit [Quit: leaving]
[11:25:49] <TheMightyBuzzard> paulej72, merged your pr despite a note on it cause it works and i can't be arsed to make it work more efficiently today.
[11:26:32] <TheMightyBuzzard> also, pr in for CSP fixage so people who insist on typing www in before soylentnews.org and our onion site users can get things like css and images.
[12:32:57] <paulej72> yay, I have the day off
[12:33:07] <paulej72> Snow
[12:37:16] <TheMightyBuzzard> woot!
[12:39:16] <paulej72> now the issue I have is we mostly have the low hanging fruit bugs fixed for 17_02. I got to decide what harder bug to work on today
[12:51:45] <TheMightyBuzzard> i'm busy with car errands today. not gonna be much more help.
[12:59:03] <TheMightyBuzzard> paulej72, do the s/noupdate/update/ change. it'll be relatively easy if slightly time-consuming.
[13:01:43] <TheMightyBuzzard> also, i like the dim the title only idear. i think i'll work on that and updating every theme to highlight new posts' title bars for those with NEW turned on.
[13:01:54] <TheMightyBuzzard> tomorrow though.
[13:02:43] <TheMightyBuzzard> gotta run the roomie around getting his truck serviced at two different places this morning.
[14:27:05] <paulej72> Site updated and new story posted https://soylentnews.org
[16:13:12] <Bytram> paulej72++
[16:13:13] <Bender> karma - paulej72: 13
[16:13:45] <Bytram> paulej72: btw, is there any restriction on nexuses that keeps me from putting a single story in multiple nexuses?
[16:18:17] <paulej72> no, it should work
[16:19:32] <Bytram> kewel! thanks!
[17:33:19] <paulej72> content security policy is blocking JS on messages.pl for non admins
[17:33:43] <paulej72> we should allow that through
[17:40:39] <Bytram> funny you should mention that... i just went through and cleared out a bunch of messages, and was surprised to see the Select All button worked fine... but I'm an admin, so that 'splains it.
[19:14:39] <paulej72> TheMightyBuzzard: CSP blocks stripe js
[20:18:00] <Bytram> ruh roh
[20:18:44] <Bytram> brb
[20:26:37] <paulej72> OK i was working all afternoon working on JS based expand all button
[20:26:43] <paulej72> for comments
[20:28:48] <paulej72> OK doing this with a JS only solution would be rather difficult as it rquires dom tree traversal and searching. It is a piece of cake with jQuery which is loaded for admins already
[20:31:18] <paulej72> I currently have it currently in a test mode on dev. any admiin will see clicking collapse comenet will collapse childeren. This was proof of concept and we would probably have a new button to change states
[20:31:58] <paulej72> from collapse comments.js
[20:32:00] <paulej72> / [+] and [-]
[20:32:00] <paulej72> / Expand or collapse a single comment.
[20:32:00] <paulej72> /
[20:32:00] <paulej72> / If a comment is in a collapsed state on the original page, it is
[20:32:00] <paulej72> / loaded from the page to which that comment links. All other comments
[20:32:01] <paulej72> / that are shown on that page are also loaded, but not expanded.
[20:32:11] <paulej72> / [++]
[20:32:11] <paulej72> / Expand all comments in this branch.
[20:32:11] <paulej72> /
[20:32:11] <paulej72> / All loaded comments are expanded, and all comments from the page of
[20:32:11] <paulej72> / the nearest comment that has not yet been loaded are loaded and
[20:32:13] <paulej72> / expanded. Thus, repeated clicking on this button will load and display
[20:32:17] <paulej72> / all comments in this branch.
[20:32:19] <paulej72> /
[20:32:21] <paulej72> / This also shows all hidden comments in this branch.
[20:32:28] <paulej72> /
[20:32:28] <paulej72> / [--]
[20:32:28] <paulej72> / Collapse all comments in this branch.
[20:32:29] <paulej72> /
[20:32:31] <paulej72> / [.]
[20:32:33] <paulej72> / Hide or show all replies to this comment.
[20:32:35] <paulej72> /
[20:32:37] <paulej72> / This does not affect the loading of the hidden comments with the above
[20:32:39] <paulej72> / buttons.
[20:32:41] <paulej72> /
[20:32:43] <paulej72> / Hiding also collapses the comment.
[20:34:20] <paulej72> with the js we could do this all, but I would think having a third button that is just a open all in thread, leaving the current buttons as they are.
[20:35:15] <paulej72> call it +++ or something
[20:36:58] <paulej72> I have all piece we need I would just need to code it up and make the buttons pretty
[20:58:41] <Bytram> paulej72: will give it a try, soon. One thing, though... last I checked we are currently running an unsupported version of jquery. Several releases back I noticed this and we upgraded (to version 2 or so), but there has been a regression and we are back to version, what, 1.3?
[20:58:45] * Bytram goes to check...
[20:58:51] <Bytram> here we go: #request# GET https://soylentnews.org
[20:59:44] <Bytram> http://jquery.com
[20:59:52] <Bytram> http://jquery.com
[21:00:04] <Bytram> current version is v3.1.1
[21:01:41] <Bytram> is only 32kb minified and gzipped
[23:05:49] <paulej72> yeah we should probably push that out to dev and see what breaks
[23:07:01] <Bytram> might be best to avoid x.0.0, right? =)
[23:07:53] <Bytram> otoh, I suspect there may be things that were EOL'd, so maybe start at, say, v2.1.0 or something like that
[23:08:35] <paulej72> well we could rtfm and see what was deprecated
[23:08:50] <Bytram> yeah, that's the word I was looking for!
[23:09:15] <Bytram> but... what would the fun be in that? Would we even recognize what is deprecated and whether or not we actually used it?
[23:09:37] <paulej72> but given most of our code we use it for is deprecated it may be a wash
[23:09:55] <Bytram> ROFL!
[23:10:13] <Bytram> ru roh... am having some network problems
[23:10:40] <paulej72> jquery is loaded by the ajax module that was used for D2.
[23:11:13] <paulej72> there are a few JS based admin tools that use it as well. That is why we have not pulled it out completly
[23:11:51] <paulej72> I would love to clean up the JS and get rid of the cruft
[23:16:03] <Bytram> likewise
[23:16:13] <Bytram> there's some stuff that gets loaded on the main page, IIRC
[23:19:02] <paulej72> load timer stuff that is broken
[23:19:33] <Bytram> yep, that's the stuff
[23:51:34] <Bytram> break time