#dev | Logs for 2017-02-28

« return
[00:07:38] <paulej72> Bytram: is there a current dev story that has a bunch of comments (ie a couple of pages) that I can mod and post to. If not can you create one
[00:12:36] <Bytram> paulej72: Hi! let me take a look... brb
[00:13:36] <Bytram> paulej72: how many comments do you need/want?
[00:14:08] <paulej72> more than 20 tlcs
[00:14:17] <Bytram> and how deep do you want the comments to go, 4 or 5 levels?
[00:14:54] <paulej72> two will be fine only testing pagination redirects
[00:14:58] <Bytram> lastly, do you want multiple comments at a given level or can it go straight from TLC down to great-great-grandchild?
[00:15:07] <Bytram> oh
[00:15:17] <Bytram> so TLC > child1 and Child 2?
[00:15:35] <paulej72> they could even be jsut tlc>child1
[00:15:59] <Bytram> easy peasy... give me a few minutes
[00:16:19] <Bytram> now where did I put that automation again? =)
[00:27:30] <paulej72> Bytram: is it ok to deploy on dev?
[00:35:24] <Bytram> I just finished coding up the automation and am about to let it loose on dev
[00:35:44] <Bytram> are you planning to bounce the erver or anything?
[00:35:58] <Bytram> the code is not the most tolerant of server glitches :/
[00:37:03] <Bytram> paulej72: am about to set it off... will keep you posted
[00:38:12] <Bytram> first comment posted okay... automation begins!
[00:38:49] <Bytram> that's 10 out of 60 posted
[00:39:44] <Bytram> and there's 20 out of 60
[00:40:30] <Bytram> ... 30 out of 60
[00:41:12] <Bytram> ... 40 out of 60
[00:41:56] <Bytram> ... 50 out of 60
[00:42:51] <Bytram> ... 60 out of 60
[00:43:23] <paulej72> hrmm, broke the pagination links
[00:43:40] <Bytram> and it looks like I made 18 or so TLCs
[00:43:49] <Bytram> https://dev.soylentnews.org
[00:45:06] <paulej72> I know what I did
[00:45:31] <Bytram> nice!
[00:47:35] * Bytram just realized he might have an extensive, umm, comment history =)
[00:49:12] <Bytram> "martyb's Latest 60 of 2300 Comments" https://dev.soylentnews.org
[00:49:22] <paulej72> ok that was not the problem, but I know what is now
[00:49:46] <Bytram> Funn with Venn
[00:50:52] <paulej72> this issue may be harder to fix
[00:51:03] <Bytram> what is the issue?
[00:51:26] <paulej72> overwriting a var
[00:51:37] <paulej72> but I just need to test for it first
[00:51:51] <Bytram> nod nod
[00:57:26] <paulej72> matching parens is hard
[00:57:49] * Bytram has done limited programming in lisp -- pre-IDE
[00:59:49] <paulej72> OK the links are putting out the correct vals, I am just not getting the data passed through
[01:03:23] <Bytram> TheMightyBuzzard: FYI, after PJ requested a test story on dev with a bunch of comments he could mess around with, I decided it would be trivial to make another story for you... enjoy: https://dev.soylentnews.org
[01:04:16] <Bytram> .op
[01:04:16] -!- mode/#dev [+o Bytram] by Hera
[01:04:21] -!- exec [exec!~exec@crutchys.brothel] has joined #dev
[01:04:27] <Bytram> .deop
[01:04:27] -!- mode/#dev [-o Bytram] by Hera
[01:04:42] <Bytram> let's try that again: https://dev.soylentnews.org
[01:04:54] <Bytram> ~titles on
[01:05:09] <Bytram> ~title on
[01:05:10] <exec> titles enabled for 10#dev
[01:05:15] <Bytram> =)
[01:06:48] <Bytram> third time's the charm: https://dev.soylentnews.org
[01:06:53] <exec> └─ 1320170227b - Buzz's Barnyard - Dev.SN
[01:06:57] <Bytram> =)
[01:39:24] <paulej72> OK got the redirects working properly
[01:40:54] <paulej72> links are showing the correct data now.
[01:41:06] <Bytram> !woop
[01:41:06] <Bender> woop woop woop (\/) (;,,;) (\/)
[01:41:09] <Bytram> paulej72++
[01:41:09] <Bender> karma - paulej72: 11
[02:10:00] <paulej72> The links for reply to article will not allow us to redirect to the reply driectly as we don't know which page it will end up on.
[02:10:30] <paulej72> so it will defult to page 1 and it will work for most shorter articles
[02:16:47] <Bytram> so, if in my preferences, I have my comments-per-page set to 100 (default IIRC), and I try to post a TLC to a story that already has over 100 comments, when I click "Reply to Article" type a comment and hit submit, it would *ordinarily* reload the story and pre-position me at the comment I just posted, but because of paging issues, that won't work in this cse.
[02:17:04] <Bytram> is that correct?
[02:34:53] <Bytram> paulej72: TheMightyBuzzard: Looks like we have a problem with the user's comments page. All links to the user's comments appear to be to the meta nexus. For example, see: https://soylentnews.org
[02:34:55] <exec> └─ 13Entropy - SoylentNews User
[02:37:22] <Bytram> scroll down to the section where it lists the "Latest 24 of nnn Comments" and hover over any of the comment litlelinks on the LHS -- all point at the Meta nexus, even though it seems all of the "attached to" <story links> are NOT to the meta nexus.
[04:40:52] <chromas> What if the *NEW* was replaced by a left border highlight or something else less shocking?
[12:13:18] <paulej72> TheMightyBuzzard: I have not deployed my fixes from last night to prod. Take a look at the pull request and see if I missed anything.
[12:43:52] <Bytram> chromas: interesting idea, but I do not think that would work unless the comment was fully expanded -- the "unbordered" title bar has no color at all
[15:11:18] <TheMightyBuzzard> paulej72, will do
[15:16:13] <paulej72> TheMightyBuzzard: one of the damn admin pages is spamming the error log
[15:17:33] <TheMightyBuzzard> it can suck a dick till we get less people up our asses i'm thinking. prolly an easy fix but for not a lot of gain.
[15:17:54] <paulej72> just makes it hard to parse for real errors
[15:18:32] <TheMightyBuzzard> ahh, well if it bugs ya i'll fix it.
[15:20:54] <paulej72> no only if you feel like it
[15:21:19] <paulej72> sub getCommentsForUser needs fixed in MySQL.pm
[15:21:30] <TheMightyBuzzard> paulej72, pr looks good. merging.
[15:21:37] <paulej72> [Mon Feb 27 08:17:48 2017] [error] /comments.pl:Slash::DB::Utility:/srv/soylentnews.org/perl/lib/perl5/site_perl/5.20.1/Slash/DB/Utility.pm:788:virtuser='slash' -- hostinfo='Localhost via UNIX socket' -- Column 'cid' in where clause is ambiguous -- SELECT comments.cid, date, date as time, subject, nickname, homepage, fakeemail, users.uid AS uid, sig, comments.points AS points, pointsorig, tweak, tweak_orig, subject_orig, pid, pid AS
[15:21:37] <paulej72> original_pid, sid, lastmod, reason, journal_last_entry_date, ipid, subnetid, karma_bonus, len, badge_id, comment_text.comment as comment, subscriber_bonus FROM comments LEFT JOIN comment_text ON comments.cid=comment_text.cid LEFT JOIN users ON comments.uid=users.uid WHERE sid='17968'AND (comments.points >= '-1' OR comments.uid=5660 OR cid=472120) ;; Which was called by:Slash::DB::MySQL:/srv/soylentnews.org/perl/lib/perl5/site_per
[15:21:37] <TheMightyBuzzard> howzat?
[15:21:38] <paulej72> l/5.20.1/Slash/DB/MySQL.pm:6462
[15:22:02] <TheMightyBuzzard> ahh, roger
[15:22:24] <TheMightyBuzzard> we don't use it on new stories anymore but slashd does
[15:23:37] <paulej72> 6450 6455
[15:24:51] <TheMightyBuzzard> okay, i'll hit that one first then look into the admin one then take care of notsanguine's bug
[17:56:41] <lemon> hey the new chevron buttons are pretty clever, I approve
[18:44:29] <cmn32480> TheMightyBuzzard ^^^ the is one guy who likes them!
[18:49:52] <paulej72> yeah
[18:51:53] <cmn32480> obviously he's a lemon
[18:55:41] <paulej72> todo add #cid to the links in the messges about comment replies
[18:55:54] <lemon> i like them because they work without js, much more convenient than opening every hidden comment in a new tab
[22:24:24] <TheMightyBuzzard> lemon, thanks yo. it's nice to be appreciated once in a while.
[22:27:16] <TheMightyBuzzard> paulej72, notsanguine's bug is caused by the shit in MySQL.pm starting at 6382 but i can't wrap my head around how to rewrite it so it actually works right now. if you want to finish it there's two other bug fixes in that branch otherwise i'll get to it probably this evening sometime if my head clears up.
[22:48:50] <TheMightyBuzzard> paulej72, i think ima write up a nested mode tomorrow that's TNG but ignores threshold and breakthrough entirely. i think we should set that to the default view for ACs since most of them are bitching about having to change those settings every time to see all the comments.
[22:50:24] <TheMightyBuzzard> wait, no. hows about we just set AC Breakthrough to -1 and move them to TNG?
[23:00:35] <paulej72> yeah I like that last one
[23:01:00] <paulej72> set threshold to -1 as well
[23:03:34] <paulej72> TheMightyBuzzard: well your asking the wrong person here
[23:03:52] <TheMightyBuzzard> isn't a threshold on TNG, remember?
[23:04:46] <TheMightyBuzzard> man, i wish to fuck people would just log in. no matter what mode we make AC default, tons of people are gonna bitch.
[23:04:52] <paulej72> yes, but I think the code shits it self if t<=b
[23:05:18] <TheMightyBuzzard> vice versa?
[23:05:44] <TheMightyBuzzard> but yeah, set em both to -1 for AC
[23:05:54] <paulej72> threhs nnesds to below or equla to b but I need to see what the code does for sure
[23:06:15] <paulej72> I ran into the problem in testing, but I negleted to fix it
[23:06:20] <TheMightyBuzzard> oops
[23:07:01] <paulej72> what is the second for each loop doing the temphr var
[23:09:03] <TheMightyBuzzard> it should be filling @tempcomments up with an array of comments but i had a bug in it where it was filling it up with cids.
[23:09:56] <TheMightyBuzzard> then it should be pushing that array onto an array existing above that scope, @$newcomments
[23:10:09] <paulej72> foreach my $C (keys %$temphr)
[23:10:20] <paulej72> those are cids in $C
[23:10:30] <paulej72> my $walker = $C;
[23:10:36] <TheMightyBuzzard> ya, i fixed that on dev already but still getting an empty array
[23:10:43] <paulej72> walker is a cid
[23:10:52] <paulej72> ok ill look at that code
[23:11:40] <TheMightyBuzzard> really it needs rewritten anyway since i figured out that code should be able to cause the inclusion of a comment more than once given vigorous enough branching
[23:14:32] <TheMightyBuzzard> hell, i coulda just used values %$temphr
[23:15:10] <TheMightyBuzzard> or gone through @$comments even
[23:15:31] * TheMightyBuzzard shurgs
[23:16:05] <TheMightyBuzzard> i'll be back around 8 eastern and rewrite the bitch if you haven't already got it working
[23:16:55] <paulej72> TheMightyBuzzard: if we are doing flat, are we not jsut pulling x comments from the db for an sid orderd by time?
[23:17:37] <TheMightyBuzzard> we could i suppose but i was gonna only drop the children of that comment in there to be useful
[23:18:25] <paulej72> If we have cid only then we pull just one comment out, not its tree in flat mode
[23:18:53] <TheMightyBuzzard> shurg. that's easy then.
[23:19:38] <paulej72> that is how I expect flat to work, but I have no idea if slash expects it that way
[23:20:02] <TheMightyBuzzard> rehash does wtf we tell it. i dunno how users expect it to do though.
[23:20:15] <TheMightyBuzzard> notsanguine would know
[23:22:04] <TheMightyBuzzard> we could just show direct replies to it. select blah from argh where pid = $cid or cid = $cid
[23:23:40] <TheMightyBuzzard> okay, that's what we're gonna do
[23:47:33] <paulej72> fuck the save checkbox is not working in the box above hte comments
[23:50:42] <paulej72> never mind, it does
[23:53:43] <TheMightyBuzzard> yays!