#dev | Logs for 2017-02-26

« return
[04:57:27] <charon> TheMightyBuzzard: Having trouble with links to comments individual comments. The error message is "We can't find a comment with that ID (471733) in this discussion (17968). If this comment was posted moments ago, please wait 60 seconds for it to appear. Otherwise, if you got here through a link generated by SoylentNews, please report this as a bug. But if you got here thanks to a silly user's comment text or journal entry or something, or from
[04:57:27] <charon> an external site, this link is just invalid -- sorry. "
[04:58:53] <charon> it's happening on every comment link i've tried so far
[08:38:29] -!- mecctro_ has quit [Quit: Leaving]
[11:14:51] <TheMightyBuzzard> charon, shit
[11:32:12] <TheMightyBuzzard> paulej72, looks like we're getting mostly pretty useful constructive criticism so far. wanna run with whatever we can get done by friday and roll it out next weekend? mostly cosmetics i think.
[11:32:30] <TheMightyBuzzard> charon, cannot replicate. got a link?
[11:49:27] <TheMightyBuzzard> paulej72, there's a few i'd like to get done today and rolled out by this evening though like username links fixing in the comment titles.
[12:41:04] <paulej72> yep, I have some css to fix that should be dead simple. and some of the other ideas may or may not be easy fixes.
[12:42:39] <paulej72> yes the title links is the one I was thinging of. I can work on that right now
[12:49:31] <TheMightyBuzzard> paulej72, cool cool. i'll leave the morning work to you and see what low-hanging fruit is left a little later.
[12:51:16] <TheMightyBuzzard> could ya add 0.5-1em of margin-left to the preview/submit buttons while you're at it? dude says it's rough to hit the right one on a phone and after testing i agree.
[13:04:37] <paulej72> yeah going to try that and adding more max height before scrollbars
[13:05:54] <TheMightyBuzzard> sounds good. whadda ya think of changing ACs to TNG so they don't have to hit all kinds of clicks/pokes to see all comments?
[13:26:33] <TheMightyBuzzard> paulej72, i'll answer our first riot comment (471836) keep on coding.
[13:33:18] <paulej72> Probably a good idea fro ACs
[13:35:20] <TheMightyBuzzard> we should put a poll up for it after we switch them to TNG and run a story asking them to try both modes and vote on which they prefer.
[13:36:21] <Bytram> hi!
[13:36:57] <Bytram> poll on TOS vs TNG sounds good,we are due for one, anyway
[13:37:23] <Bytram> I did not realize that some options on the user's preferences page had been removed as part of the comments upgrade
[13:38:07] <Bytram> only 5-6 lines displayed on a comment before scroll mode sucks on my mobile... narrow screen only puts up like 50-60 words.
[13:38:19] <Bytram> having to internally scroll most every comment is a PITA
[13:38:55] <Bytram> also, if i accidentally tap-and-drag in the middle of a scrollable comment i cannot scroll the whole screen.
[13:39:45] <Bytram> or, put another way, I'm tying to scroll down through the entire comment section and depending on whether or not I tap on a scrollable comment, I see either a comment scroll or the whole comment window scroll.
[13:40:27] <Bytram> I normally ran with the maximum amount of comment rtext displayed before I would see the "Read the rest of th comment" -- I thnk I had it set for something like 64k or 128k or somthing like that.
[13:41:07] <Bytram> also, on my mobile, the chevrons are only about 4-5 pixels wide/tall -- virtually impossible to hit without zooming, first
[13:41:43] <TheMightyBuzzard> Bytram, current poll is like days old, ain't it?
[13:42:20] <Bytram> oh, it just got changed. :/ it had been about 3 weeks before that. nvm
[13:42:37] <TheMightyBuzzard> paulej72, whatcha think about a user pref to enable long comment scrolling and defaulting to showing the full comment?
[13:44:12] <TheMightyBuzzard> or maybe counting p tags in the comment and giving tall comments a scrollme class?
[13:44:52] <Bytram> TheMightyBuzzard: I thnk there is gret value in having the old control which a user could set a limit on how much of a long comment displayed before the "read rest of coment displayed" -- a troll could paste in a massive doc just for the lulz
[13:45:28] <Bytram> hmmm, are there <p> tags in ecode? or in plain text?
[13:45:59] <TheMightyBuzzard> i have no idea
[13:46:27] <Bytram> that was a rhetroical question. there are none in those modes, AFAIK
[13:47:57] <TheMightyBuzzard> but yes, there are p tags in plain text as rendered
[13:48:40] <TheMightyBuzzard> or at least br tags, which can also be counted
[13:48:40] <Bytram> really? I thought htat was implemented as a bunch of <br> tags, one after each /n
[13:49:17] <Bytram> why not just count bytes and set a limit based on that (i.e. the old way)?
[13:49:55] <TheMightyBuzzard> cause <p> is only three bytes
[13:50:58] <Bytram> i was not clear.
[13:51:42] <TheMightyBuzzard> the old way, you could write a comment reading <p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>.<p>. and it would never scroll/get shortened
[13:52:11] <Bytram> I mean, instead of scanning through the entire comment and counting how many times "<p>" (or "br>") *appear*, just count the number of butes in the entire comment, and let the user set a threshold on how many bytes appear before they see a "read the rest of this comment..." link
[13:52:31] <TheMightyBuzzard> four bytes per line is a hell of a lot of lines before doing anything about shortening it
[13:53:04] <Bytram> hmmm
[13:53:21] <Bytram> part of me wants to say thta "<p>.<p>.<p>.<p>.<p>.<p>." is a feature
[13:53:27] <TheMightyBuzzard> lol
[13:53:56] <TheMightyBuzzard> there's prolly a way to do it via css for anything over Nem size.
[13:54:23] <Bytram> how about spillover after "[ nnn]" "[characters|paragraphs]
[13:55:26] <Bytram> be aware that on seeing THAT, I would expect that "<br>something<br>and more<b> and some more" should be treated as 3 paras.
[13:55:50] <Bytram> also, a single line, but contains 32k chars could also be a single paragraph.
[13:57:22] <Bytram> hmmm, "<div style='height:9999em'>" where the '9999' could be user-settable?
[13:58:34] <Bytram> so, where you currently set things to make a single comment scrollable, allow THAT amount to be user setable, yes. (Set to 0 for unlimited; i.e. remove single-comment-scroll entirely)
[13:59:12] <Bytram> coffee++
[13:59:12] <Bender> karma - coffee: 8
[13:59:53] <Bytram> the prior things were some of what I noticed last night while reading SN between sleep periods...
[14:00:23] <Bytram> don't have a heck of a lot of time before I need to head to work today. Have tomorrow off, but some errands to run, too.
[14:01:16] <Bytram> just popped in here soon as I woke to gt these things to ya before I forgot them. Am gonna get ready and then pop inwith whatever else I can find
[14:01:17] <Bytram> afk
[14:04:57] <TheMightyBuzzard> paulej72, angry dude and a couple others got a beef with having the username and badges in the titles and i kinda agree that it's information overload up there. whatcha think about moving it back?
[14:21:29] <paulej72> can't easily as it is needed for collapsed version of the comment
[14:21:58] <TheMightyBuzzard> is it really though?
[14:22:29] <paulej72> yes as a collapsed comment withouth that info is worthless
[14:22:56] <TheMightyBuzzard> hrm...
[14:23:09] <paulej72> and collapsing all but the h4 is easy
[14:23:56] <paulej72> it could be done, but it would require building extra text that is hidden when the comment is not collapsed
[14:24:07] <TheMightyBuzzard> okay, i'll monkey with having it only show up when collapsed and doing +/- instead of chevrons after you get done
[14:24:12] <paulej72> what could be done is styling it differently
[14:25:06] <paulej72> but I would rather not as it is bunch of extra code that is diplayed or hidden for each comment. It would increas load and render times
[14:26:15] <TheMightyBuzzard> nah, stick it in a var and just "stuff".$var."stuff" it twice then let css determine the hidden/not status of it.
[14:26:32] <TheMightyBuzzard> no speed decrease to speak of
[14:26:59] <paulej72> I liked the idea of the headers not changing much when a comment collapsed
[14:27:45] <TheMightyBuzzard> me too in theory but i took another look after the bitching and now i kinda agree with them
[14:37:33] <paulej72> fixes for usernames, min-height, preview box, and button padding on comment pages has been deployed on dev
[14:38:57] <Bytram> back for a short bit... just changed view of site from TOS to TNG
[14:39:11] <TheMightyBuzzard> did you find the preview box bug?
[14:39:20] <TheMightyBuzzard> i couldn't replicate it.
[14:39:22] <paulej72> yeah
[14:39:24] <Bytram> maybe a two-line <h4> with a <BR> between title and the rest (or some other division)
[14:39:44] <TheMightyBuzzard> sweet
[14:39:49] <paulej72> li tag used to be applied in dispComment but was no longer
[14:40:01] <TheMightyBuzzard> ahhhh
[14:40:50] <paulej72> Bytram: make it 1pt font
[14:41:23] <TheMightyBuzzard> ima grab a smoke n hit the head then i'll review and merge.
[14:41:35] <Bytram> actually, there are a couple times when I saw some microwscopic font -- not enough times to isloate, tho. (that was on my android mobile with chrome)
[14:42:36] <paulej72> TheMightyBuzzard: do you want me to work up the changes for moving the user and zoo back into the details div
[14:46:17] <Bytram> piece of data on usernames in comment titlebar -- I use chillax theme -- all is white on pink, normally, but once I've clicked on the user's nick and gone to their page, it becomes black text instead of white.
[14:46:26] <Bytram> may have similar things happen with other themes
[14:49:22] <Bytram> width of a user's display dramatically affects how much of a comment is displayed... seems to be n *lines* before scrolling... (note: on my mobile, scroll bars are suppressed by default unless I am actively scrolling the region)
[14:50:26] <Bytram> on my narrow mobile screen, i see maybe 60 words and then it scrolls. Much better experience on my main display 1920x1200 so there's lots more space for long lines and far fewer of the comments go into scroll mode.
[14:52:53] <Bytram> wish i could hang around and discuss with you all, am off to work and then have a function afterwards prolly won't be back for another 11-12 hours. Will look at site when I can... If I see anything really wonky, will send ya a text (if that's okay)
[14:54:43] <Bytram> that all said, it's a huge set of changes you rolled out... and I thnk the community has mostly provided constructive criticisms -- I have toruble with this/ try that -- versus just "this sucks"
[14:54:46] <Bytram> GOOD LUCK!
[14:54:54] <Bytram> TheMightyBuzzard++
[14:54:54] <Bender> karma - themightybuzzard: 8
[14:54:58] <Bytram> paulej72++
[14:54:58] <Bender> karma - paulej72: 10
[14:55:04] <Bytram> laters
[14:58:01] <TheMightyBuzzard> paulej72, actually, i was thinking of making it a user pref. put a span tag around that bit and have it hidden when expanded as the user prefers. whatcha think?
[15:00:43] <clorox|2> Needs CSS animations :D
[15:01:01] <paulej72> TheMightyBuzzard: I am just going to show it when collapsed and move back to details wehn not. we can add a pref later as I don't want to change the db for a quick fix
[15:02:03] <TheMightyBuzzard> roger. if you wanna do that, rock on. otherwise i'll do it before i monkey with dude's css for going back to +/- instead of chevrons.
[15:03:17] <TheMightyBuzzard> i don't hate the chevrons but they're not as intuitive as +/- and some folks bitched.
[15:04:03] <paulej72> I almost got the changes ready for moving the username
[15:04:09] <TheMightyBuzzard> okey doke
[15:04:49] <TheMightyBuzzard> hrm, having that hidden will make it harder to have an expand everything below a comment button
[15:04:57] <TheMightyBuzzard> maybe
[15:06:27] <TheMightyBuzzard> pretty sure a simple selector that matches all children of a div would cover expanding them all.
[15:06:59] <TheMightyBuzzard> might need !important on checked and not have !important on unchecked
[15:07:39] <TheMightyBuzzard> wouldn't work precisely like the ++ button but it'd be close enough i think.
[15:19:07] <TheMightyBuzzard> checking now
[15:23:55] <paulej72> OK moved the by line to the details
[15:24:00] <paulej72> live on dev
[15:24:40] <paulej72> !important will not fix that issue TheMightyBuzzard
[15:25:03] <paulej72> css does not work that way
[15:25:52] <TheMightyBuzzard> cool, checked, reviewed and merging.
[15:27:16] <TheMightyBuzzard> merged
[15:33:56] <paulej72> do you want me to deploy on prod?
[15:38:28] <TheMightyBuzzard> might as well, it's going to be a little bit before i can get the +/- thing squared away in my head.
[15:48:15] <paulej72> are we just trying to replace the chevrons with text
[15:48:55] <paulej72> if that is the case, I am not sure if putiing in text via css is viable on older browsers
[15:52:33] <TheMightyBuzzard> hrm... we could say screw older browsers or we could make images.
[15:53:33] <TheMightyBuzzard> it's giving me hell getting the +/- aligned correctly anyway right now so i'm voting images
[15:53:50] <TheMightyBuzzard> pretty sure i can do that in gimp in a couple minutes
[15:54:39] <TheMightyBuzzard> shit on this, i need coffee
[16:00:32] <TheMightyBuzzard> getting closer. and really i'm not concerned with all the shiny new bells n whistles functioning on ancient browsers.
[16:02:57] <TheMightyBuzzard> yeah, it'd be nice, but it ain't strictly necessary.
[16:09:28] <paulej72> well it should work in ie11 and edge which spoiler seems like is does not
[16:10:40] * TheMightyBuzzard chuckles
[16:11:10] <TheMightyBuzzard> yeah, we need to revisit spoiler anyway. it ain't gonna work for shit on phones/tablets or for disabled folks.
[16:11:52] <paulej72> yeah, going to have to be click to expand just like the icons do.
[16:12:34] <paulej72> so are we going to with + - ++ -- for the icons instead of chevrons?
[16:14:58] <TheMightyBuzzard> gonna give it a try, yeah
[16:17:31] <paulej72> TheMightyBuzzard: I am going to push a small extra css fix right now.
[16:17:39] <TheMightyBuzzard> go fer it
[16:17:55] <TheMightyBuzzard> if it's small just merge it too and push it live
[16:19:11] <TheMightyBuzzard> yeah, these need to be fucking images. this shit's giving me hell trying to get it to play nicely with before/after
[16:19:30] * TheMightyBuzzard whips out gimp
[16:20:38] * cmn32480 covers his eyes in horror
[16:33:54] <TheMightyBuzzard> paulej72, fuck da police. i don't feel like coding/gimping any more right now. if you wanna replace the chevrons, have at it. ima come back and try and explode a whole comment tree with one button in a while.
[16:48:07] <paulej72> OK, I have another fix I want to test on dev and deploy on live. Any issues with that TheMightyBuzzard
[16:48:22] <TheMightyBuzzard> newp
[16:49:25] <TheMightyBuzzard> in fact i grant my approval for anything of under fifty lines and less than 10% of the changes being perl for the rest of the day.
[16:49:56] <TheMightyBuzzard> cause i'm going to be outside soaking up some sunlight and getting non-computey things done for a bit.
[16:51:41] <paulej72> ok
[19:00:23] -!- charon_ [charon_!~0c0959f3@Soylent/Staff/Editor/charon] has joined #dev
[19:01:49] <paulej72> OK added new comment limit filter to dev and prod and removed the scrollbar for comments
[19:10:44] <charon_> TheMightyBuzzard: every comment link in threads from this one: https://soylentnews.org and previous shows that error for me. more recent threads do not.
[19:10:46] <aqu4>  ^ "3Original Star Wars Trilogy Theatrical Cuts To Be Released On Blu-Ray - SoylentNews"
[19:11:39] <charon_> story that is. not thread. because it's every thread in every story
[19:21:44] <paulej72> charon_: which links exactly
[19:23:20] <charon_> sec
[19:23:41] <charon_> https://soylentnews.org
[19:23:43] <aqu4>  ^ "3SoylentNews Comments | Original Star Wars Trilogy Theatrical Cuts To Be Released On Blu-Ray"
[19:24:01] <charon_> and every other direct link to an individual comment
[19:25:16] <charon_> balls
[19:25:31] <charon_> i just tested it while logged out, as an AC that link works
[19:25:53] <charon_> so it must be something in my user settings
[19:30:49] <paulej72> it works fine for me charon_ logged in, are you using the editor's greasemonkey script?
[19:31:04] <charon_> yes i am.
[19:31:13] <paulej72> I blame that.
[19:31:38] <paulej72> it usually need tweaked after every major update.
[19:32:40] <charon_> just turned off Greasemonkey: same error. reset user prefs to default: same error.
[19:33:09] <paulej72> what is the error?
[19:33:13] <charon_> was happening on two different computers also
[19:33:40] <charon_> The error message is "We can't find a comment with that ID (471733) in this discussion (17968). If this comment was posted moments ago, please wait 60 seconds for it to appear. Otherwise, if you got here through a link generated by SoylentNews, please report this as a bug. But if you got here thanks to a silly user's comment text or journal entry or something, or from an external site, this link is just invalid -- sorry. "
[19:37:15] <charon_> could it be my seclvl? which i have no idea what it is or what it does
[19:37:19] <paulej72> was that the error from the link above?
[19:37:32] <charon_> but i know staff have one
[19:38:21] <charon_> no, but the only difference is the numbers for sid and cid. almost every comment gives that same error with only the numbers different
[19:38:59] <charon_> sorry, i copy/pasted that from the page i was on when you asked. i've been testing a ton of comments from all over
[19:47:28] <paulej72> TheMightyBuzzard: single comment views where cid cid is set are borked, You are not setting the <ul class="commentlisting"> around the comments, which is needed for a bunch of css to be set
[19:47:38] <charon_> it's hopefully not a big deal, since more current comments are working alright.
[19:59:16] <paulej72> not a real big deal, but it does mess up the left borders that let the users see the levels easily
[20:38:13] <paulej72> TheMightyBuzzard: fix made
[23:46:58] -!- charon_ has quit [Quit: ogun]