#dev | Logs for 2017-02-20

« return
[00:10:35] <NCommander> I'll dig into it in a bit
[00:16:23] <Bytram> paulej72: In a word: WOW! That is an amazing cleanup!
[00:18:50] <Bytram> There were some issues in the code that had kept me from getting a clear mental model of what was going on... things are MUCH clearer, now!
[00:19:14] * NCommander is vaping and watching an incense stick burn
[00:20:12] <Bytram> So, that leads me to ask a question...
[00:20:29] <Bytram> on production, let's take a look at this story: https://soylentnews.org
[00:20:32] <aqu4>  ^ "3Robots That Steal Human Jobs Should Pay Taxes, Gates Says - SoylentNews"
[00:20:51] <Bytram> I set Threshold:5 Breakthrough:5
[00:21:12] <Bytram> No matter which display mode I select, I see: "16 replies below your current threshold"
[00:21:44] <NCommander> Bytram, right?
[00:21:52] * NCommander notes that's correct
[00:21:55] <Bytram> here's a link: https://soylentnews.org
[00:21:56] <aqu4>  ^ "3SoylentNews Comments | Robots That Steal Human Jobs Should Pay Taxes, Gates Says"
[00:22:05] <Bytram> and with what's on dev, let's look at:
[00:22:13] <Bytram> https://dev.soylentnews.org
[00:22:15] <aqu4>  ^ "320170215e - Test Story - Please DO NOT Moderate and DO NOT Post Comments - Comment Score Testing - Dev.SN"
[00:22:28] <NCommander> Yeah that's a bug
[00:22:36] <NCommander> Threshold is supposed to affect top level comments
[00:22:41] <Bytram> It seemslike we have a NEW rule, that top level comments ALWAYS gets displayed
[00:22:43] <NCommander> Breakthrough is (currently) ignored for top level comments.
[00:24:17] <Bytram> No matter which mode I select on DEV, when I set T:5 and B:5, it always displays TLC (Top Level Comments) no matter what the score.
[00:24:39] <Bytram> so, this IS a bug and needs to be fixed before go-live?
[00:25:09] <Bytram> I can quite easily imagine someone taking advantage of that "feature" and posting a non-hidable diatribe
[00:25:32] <Bytram> well, not non-hidable, but default to being fully-displayed
[00:28:17] <Bytram> Imagine if every wacko with an agenda (deuteronomy child brides, penis bird, cheap canadian little-blue-pills on-line) taking advantage of that.
[00:34:48] <Bytram> .
[00:35:38] <Bytram> New question: Am I missing something or should: (T:-1, B:5) produce the same result as: (T:5, b:-1)
[00:36:28] <Bytram> Under Threaded-TOS, I'm seeing different results on: https://dev.soylentnews.org
[00:36:29] <aqu4>  ^ "320170215e - Test Story - Please DO NOT Moderate and DO NOT Post Comments - Comment Score Testing - Dev.SN"
[00:36:45] <Bytram> T:-1, b:5 -- https://dev.soylentnews.org
[00:36:47] <aqu4>  ^ "320170215e - Test Story - Please DO NOT Moderate and DO NOT Post Comments - Comment Score Testing - Dev.SN"
[00:37:08] <Bytram> T:5, BV:-1 -- https://dev.soylentnews.org
[00:37:09] <aqu4>  ^ "320170215e - Test Story - Please DO NOT Moderate and DO NOT Post Comments - Comment Score Testing - Dev.SN"
[00:38:52] <Bytram> Based on what I understand, T:-1, B:5 Says show me everything (scoring -1 or better) in full (oh, and boost visibility of those scoring 5 or better) -- but we are already selecting to show everything anyway
[00:39:48] <Bytram> OTOH, t:5, B:-1 Says show me only those scoring 5 or better (there are none for that story), but boost all those scoring -1 or better, which is ALL of the comments, so it again selects to display everything.
[01:24:08] <TheMightyBuzzard> Bytram, threshold only controls whether the comments are hidden by the hidey message
[01:24:29] <TheMightyBuzzard> it has nothing to do with whether an individual comment is expanded
[01:25:26] <TheMightyBuzzard> NCommander, re: top level comments always being expanded: i thought that's how you wanted it so that's how i coded it. can change it easily enough.
[01:28:38] <NCommander> TheMightyBuzzard, expanded regardless of breakthrough, not threshold :)
[01:28:56] <TheMightyBuzzard> fair nuff
[01:29:04] <Bytram> https://dev.soylentnews.org says, wrt Threshold: " Comments scored less than this setting will be ignored. Anonymous posts start at 0, logged in posts start at 1. Moderators add and subtract points according to the Guidelines "
[01:29:04] <aqu4>  ^ "3Log In"
[01:29:10] <TheMightyBuzzard> be an easy fix after i review pj's pr
[01:29:20] * NCommander is extremely low energy and kicks himself
[01:29:22] <TheMightyBuzzard> may do it in the morning though
[01:29:55] * Bytram has been fighting low-energyfor the past two/three days, too. No fun.
[01:31:01] <cmn32480> bytram - not to interrupt, but have you heard any word from janrinok?
[01:31:42] <Bytram> Umm, not 'cept his initial comment in IRC a few days(?) ago.
[01:31:46] <TheMightyBuzzard> fek, i can't review that pr tonight. i'm all full of dinner and not in brain usage mode.
[01:31:49] <cmn32480> 00-4
[01:31:50] <Bytram> u?
[01:31:52] <cmn32480> 10-4
[01:31:53] <cmn32480> nada
[01:31:56] <Bytram> k
[01:32:17] <cmn32480> no reply to my email
[01:32:47] <Bytram> sadly, this just reminded me that Stuart McClain (sp?) of "The Vinyl Cafe" recently passed away. He will be missed.
[01:32:55] <Bytram> a story teller of the highest order.
[01:33:53] <Bytram> Stuart McLean: https://en.wikipedia.org
[01:33:54] <aqu4>  ^ "3Stuart McLean - Wikipedia"
[01:34:11] <Bytram> Vinyl Cafe: https://en.wikipedia.org
[01:34:11] <aqu4>  ^ "3The Vinyl Cafe - Wikipedia"
[01:36:23] <TheMightyBuzzard> nah, that was an easy enough read. assuming it passed the bytram challenge, it's mergeable.
[01:55:23] <Bytram> TheMightyBuzzard: what did you read? The update to the comments preferences page?
[02:02:11] <TheMightyBuzzard> the code for it, yeah
[02:09:09] <Bytram> nod nod
[02:11:25] <Bytram> btw, there have been several reports over the past few days 9and I've seen it to) where I go to load/refresh a page on prod and it comes up with just a "white page" -- no error message, but no page either.
[02:12:07] <Bytram> related, when I updated the template to add "Page:" on dev, it took a long time for the change to propagate, and STAY there. Kept appearing and disappearing...
[02:12:41] <Bytram> ISTR we had a problem quite a while ago with the cache getting 'confused' --
[02:13:30] <Bytram> do we still use varnish or some other kind of cache?
[02:43:58] <TheMightyBuzzard> varnish but each separate apache process will keep a separate instance of the template in memory. they likely only get refreshed when enough requests have come in to a process to make it exit and spawn a new one. this would explain why dev updates much, much slower than prod.
[02:46:54] <Bytram> hmmm, ahh! Got it! Thanks a bunch for the clear explanation! I'm guessing the only way to overcome that is to bounce the apache server(s)?
[02:49:40] <TheMightyBuzzard> basically
[02:49:55] * cmn32480 passes the ball the TheMightyBuzzard
[02:50:06] <TheMightyBuzzard> i have a shell script to do that in my ~/bin/ directory you're welcome to use
[02:50:15] <TheMightyBuzzard> /home/bob/bin/bounce
[02:51:08] <Bytram> is that on berylium?
[02:51:14] <TheMightyBuzzard> lithium is dev
[02:51:18] <TheMightyBuzzard> or ssh dev
[02:51:48] <Bytram> oh, so your script bounces the dev server, kewel. Is there one to bounce prod, too?
[02:52:11] <Bytram> we've had several reports over the past tw/three days of blanks pages being displayed on prod
[02:52:14] <Bytram> and I've seen it, too.
[02:52:26] * cmn32480 is having de ja vu
[02:52:34] <cmn32480> all over agin
[02:53:07] <TheMightyBuzzard> Bytram, yeah, same script, same place on both hydrogen and fluorine
[02:53:22] <Bytram> Noice! Mare See buckets!
[02:53:27] <TheMightyBuzzard> i bounced both web frontends earlier today though so they don't need it.
[02:53:40] <cmn32480> so it ain't the front ends
[02:53:56] <TheMightyBuzzard> could be a code error. i'd hafta read the logs
[02:54:06] * Bytram checks his backend and notes it is firmly planted in his chair
[02:54:14] <TheMightyBuzzard> and know exactly when the bug occurred cause the logs are big
[02:54:53] <cmn32480> 19:42
[02:54:59] <cmn32480> both me and takyon
[02:55:06] <TheMightyBuzzard> utc?
[02:55:09] <cmn32480> Eastern
[02:55:12] <Bytram> EST
[02:55:17] * Bytram hit it, too.
[02:55:34] <TheMightyBuzzard> i'll look into it tomorrow. bedtime.
[02:55:41] <cmn32480> 10-4
[02:55:51] <cmn32480> ~gnight TheMightyBuzzard
[02:56:06] <Bytram> I got it too and reported it at 19:47 EST.
[02:56:09] <Bytram> ~gnight TheMightyBuzzard
[02:56:34] <Bytram> whole bunch of thanks for pounding this release into shape! I really appreciate it!
[02:56:44] <TheMightyBuzzard> yarp
[02:57:04] <Bytram> We make quite a team, yanno?
[02:57:19] <Bytram> you hide bugs and I try and find 'em!
[02:57:21] <Bytram> ;)
[02:57:46] <Bytram> but seriously that is some way cool coding you've got working there, especially with CSS - color me much impressed!
[11:18:53] <TheMightyBuzzard> meh, i ain't coding rehash this morning. ima set up a local recursive bind server.
[13:47:46] <Bytram> I'm scheduled to be at work in an hour, so it does not look like I'll get to much testing this am, either.
[13:49:14] <Bytram> Things HAVE become much clearer to me over the past few days -- lots of progress. When the TLC comments are no-longer special-cased to always appear, I think I'll be in much better shape to fully grok what [is supposed to] happen[s].
[14:02:21] <paulej72> Bytram, threshold does not change anything on tos or flat. Only breakthrough works, as it is a single control mode