#dev | Logs for 2017-02-15
« return
[23:54:08] <TheMightyBuzzard> unless: they are a top level comment or are the direct ancestors of a comment that hit breakthrough.
[23:53:36] <TheMightyBuzzard> nah, comments below threshold should show as Comment Below Threshold on TOS. with a note out beside if someone's replied to them
[23:52:48] <Bytram> =)
[23:52:46] <Bytram> what you are working on!
[23:52:30] <Bytram> and TNG is... ugh.
[23:52:16] <Bytram> and.. TOS is LIKE prod, 'cept "n comments below threshold" is rreplaced by showing the title-only version of those same comments
[23:51:33] <Bytram> k
[23:51:27] <Bytram> It's like I can see any 5 of the 9 things, just not all at once, and depending on which of the 5 I'm looking at... well, confusion ensues.
[23:51:00] <TheMightyBuzzard> ignore Threaded then. simplifies.
[23:50:46] <Bytram> it's just a few too many permutations for me to keep in my brain at one time, and when things page out, so to speak, I lose context and fail to envision the whole big picture
[23:50:35] <TheMightyBuzzard> yeah, i haven't gotten rid of it yet.
[23:50:07] <Bytram> so is there any reason we still have Threaded as a choice?
[23:49:57] <TheMightyBuzzard> yar
[23:49:51] <Bytram> I apologize; like I said I was confused...
[23:48:49] <TheMightyBuzzard> we already went over this. Threaded is nothing. it is an artifact that should not even be functioning.
[23:48:09] <TheMightyBuzzard> no but TOS should be functionally equivalent except for grouping collapsed comments into N comments below your threshold
[23:47:41] <Bytram> I thought that was the "Threaded" choice
[23:47:28] <Bytram> okay are any of the choices on dev exactly like what we have on prod right now?
[23:46:59] <TheMightyBuzzard> we can make the looks like prod version just Threaded if you like
[23:46:54] <Bytram> is why I got into programming in the first place
[23:46:47] <Bytram> I watched the TOS when it was on prime time in original release
[23:46:41] * TheMightyBuzzard chuckles
[23:46:32] <Bytram> that's the problem I LIKE star trek
[23:46:18] <Bytram> my brain reads "Threaded" (okay) "star trek reference", okay, and then gets lost!
[23:45:57] <TheMightyBuzzard> trek hater
[23:45:18] <Bytram> can we please choose different genre's? Make one of 'em B5 or SW or Dune or something *other* than Star Trek
[23:44:19] <TheMightyBuzzard> if they are it's a bug.
[23:44:13] <TheMightyBuzzard> at least they shouldn't be
[23:44:03] <Bytram> ok, which one is YOURS?
[23:43:50] <TheMightyBuzzard> not in TOS
[23:43:22] <Bytram> is further complicated that ALL of *MY* comments are always fully expanded
[23:43:05] <Bytram> hmm, that is neither of Hide/Show NOR of Expand/Collapse
[23:42:35] <TheMightyBuzzard> yeah, what i said.
[23:42:19] <Bytram> whatever you call the title-only form of the comment
[23:42:15] <TheMightyBuzzard> collapsed expanded for comments. show/hide for threads. i think
[23:41:54] <Bytram> or is that hidden?
[23:41:31] <Bytram> and the kid should be collapsed
[23:41:28] <TheMightyBuzzard> that's as prod
[23:41:24] <TheMightyBuzzard> roger
[23:41:20] <Bytram> grandkid, cause it meets the breakthrough
[23:41:13] <TheMightyBuzzard> the thread should show but only grandkid and toplevel should show
[23:41:10] <Bytram> TopLevelComment is expanded, cause it's top level
[23:40:57] <Bytram> goood!
[23:40:52] <TheMightyBuzzard> no
[23:40:41] <Bytram> wait... so if I have a tree of: toplevel comment; score 0, child -1, grandkid 2, and I have breakthrough set to 2, then ALL of those comments are expanded?
[23:39:55] <TheMightyBuzzard> though they should be collapsed unless they hit breakthrough or are a TLC
[23:39:28] <TheMightyBuzzard> any comment that hits breakthrough should be displayed and cause all its parents to have the double chevron in the show position
[23:39:18] <Bytram> contemplating
[23:38:49] <TheMightyBuzzard> unless they hit breakthrough
[23:38:32] <TheMightyBuzzard> all top-level comments should be expanded, first level comments should have both chevrons facing up.
[23:37:41] <TheMightyBuzzard> Bytram, on prod, threshold controls only whether the comment should be hidden behind a "comment below your threshold" message.
[23:37:39] <Bytram> oh, wait
[23:37:30] <Bytram> so how is Threaded on dev different from Threaded on prod?
[23:36:42] <TheMightyBuzzard> Bytram, in TOS they're supposed to work exactly like prod. in TNG it's supposed to show any comment that's >= either threshold or breakthrough
[23:36:41] * Bytram clicks TMB's link
[23:35:51] <Bytram> TheMightyBuzzard: NCommander: I'm not understanding how Threshold (T) and Breakthrough (B) are supposed to work. How is choosing: {T:x, B:y} different from {T:min(x,y), B:<anything>}
[23:34:08] <TheMightyBuzzard> "N replies below your threshold" i mean
[23:33:40] <TheMightyBuzzard> if it's significantly different in layout than prod, i can't see it aside from gathering below-threshold links together which we can't do.
[23:32:53] <aqu4> ^ "3Hang Many Comments Here - Dev.SN"
[23:32:46] <TheMightyBuzzard> NCommander, okay, now comment-layout-wise... is this more or less what you were looking for? https://dev.soylentnews.org
[23:31:39] <TheMightyBuzzard> craft the url manually and it works peachy
[23:31:07] <TheMightyBuzzard> on account of they just don't send em.
[23:30:58] <TheMightyBuzzard> yeah, the page links reset your non-default mode/threshold/breakthrough.
[23:30:03] <TheMightyBuzzard> oh, ima dubmass. had it in the wrong mode.
[23:28:56] <TheMightyBuzzard> fuck. for some reason it keeps going squirrely on page two
[23:27:57] <TheMightyBuzzard> that's on the list but one thing at a time.
[23:27:41] * NCommander approves TheMightyBuzzard's fading maneuver
[23:26:59] <TheMightyBuzzard> WOOT! think i got TNG to be NCommander approveable. fading aside and broken flat aside.
[22:40:48] <Bytram> fyi: I removed my sig on dev so the comments should be much shorter vertically
[22:40:01] <Bytram> nod nod
[22:39:55] <Bytram> umm, that was what I was reporting, a problem with 'Flat' mode with T:-1 and B:-1
[22:39:50] <TheMightyBuzzard> yeah. .= instead of = somewhere
[22:39:18] <Bytram> d0)
[22:39:18] <Bytram> HASH(0x8e72ee8)HASH(0x8088958)HASH(0x8d8c020)HASH(0x8b043b8)HASH(0x95f9c78)HASH(0x8b07788)HASH(0x8747340)HASH(0x8fdcea8)HASH(0x95fe970)HASH(0x9507d80)HASH(0x95e1450)HASH(0x808a788)HASH(0x95f7f38)HASH(0x9079a18)HASH(0x95fa848)HASH(0x9302dc0)HASH(0x8092d00)HASH(0x808acc8)HASH(0x95e1360)HASH(0x808aa88)HASH(0x950e810)HASH(0x95faa20)HASH(0x808a2a8)HASH(0x808d890)HASH(0x929bf08)HASH(0x808dfe0)HASH(0x8092580)HASH(0x808e088)HASH(0x951a528)HASH(0x87a52
[22:39:17] <Bytram> for posterity, what I saw at the comment for where I expected to see comments, was, instead:
[22:37:23] <TheMightyBuzzard> but that'll be easy to fix.
[22:37:16] <TheMightyBuzzard> also, i apparently broke Flat
[22:37:05] <Bytram> k
[22:36:56] <TheMightyBuzzard> yes, see above about getting back at it.
[22:36:47] <aqu4> ^ "320170215d - Test Story - Please Moderate but Post No Comments - Bifurcation Depth-First - Dev.SN"
[22:36:45] <Bytram> just saw some weird stuff on dev -- are you playing with it? See: https://dev.soylentnews.org
[22:36:33] <TheMightyBuzzard> slightly. head in code.
[22:36:22] <Bytram> TheMightyBuzzard: you there?
[22:14:55] <TheMightyBuzzard> Bytram, no worries. hard to debug while i'm changing things.
[22:13:26] * Bytram has been trying to get back at it, but has completely run out of energy.
[22:03:56] * TheMightyBuzzard gets back at it
[21:51:51] -!- cosurgi has quit [Ping timeout: 260 seconds]
[19:57:09] -!- janrinok has quit [Quit: Leaving]
[19:48:09] <janrinok> e.g books, games, plays, films etc
[19:47:44] <janrinok> TheMightyBuzzard, when you awake from your slumbers, could you make the new nexus Reviews rather than Books, then it will cover all relevant original-source material?
[19:42:53] <NCommander> Food makes me happy
[19:26:07] * TheMightyBuzzard heads off for his nap an hour later than planned
[19:25:52] <TheMightyBuzzard> paulej72, outstanding issues are posted to dev as stories.
[19:22:00] <TheMightyBuzzard> neato
[19:20:52] <NCommander> Yay for my project getting somewhere
[19:20:48] * NCommander has the ability to rapidly cross-compile doom for multiple architectures at once
[19:18:27] <janrinok> go for it NC - have a big one!
[19:17:51] * NCommander is debating on lunch
[19:17:47] <NCommander> ++
[19:17:44] <TheMightyBuzzard> posting up issues right now
[19:15:00] <TheMightyBuzzard> TNG i expect to be a work in progress and i plan on saying so
[19:14:43] <TheMightyBuzzard> s'fine by me
[19:14:32] <NCommander> Part of me is thinking when we deploy though we default to TOS for now so the community can give feedback on TNG
[19:14:22] <TheMightyBuzzard> oh and it's borking on collapsing things on page 2
[19:14:09] <TheMightyBuzzard> TNG or TOS? only thing wrong with TNG i think is &page is not correctly being passed like &threshold and &highlightthresh.
[19:13:05] <paulej72> Can somone post up a list of current issues with the new threading so I have something to work off of
[19:12:37] <TheMightyBuzzard> but re above... those are your main sticking points?
[19:12:06] <TheMightyBuzzard> ya, we can occasionally move pretty fast around here. or not.
[19:11:14] * NCommander has no idea what horrid things you've done in Perl so I'm only good for QA :/
[19:09:38] <TheMightyBuzzard> paulej72, roger. i'll leave it for you then and get TNG playing correctly.
[19:09:12] <TheMightyBuzzard> NCommander, i get that collapsing as you'd expect on live and throw in a selectable dimming/badge doodad you're cool to sign off on it, bugs excepted?
[19:08:37] <paulej72> I can work on it tonight, but I am busy at work right now.
[19:08:19] <TheMightyBuzzard> otherwise i'll monkey with that after i get awake again.
[19:08:01] <TheMightyBuzzard> if you wanna work on that from my directory on dev while i have me a nap, rock on
[19:07:19] <TheMightyBuzzard> yeah, i think we do
[19:07:08] <paulej72> TheMightyBuzzard: do we want to make the user selectable new badge/and-or/comment dimming
[19:06:45] <TheMightyBuzzard> okay, i can get TOS functioning like live i'm pretty sure. should have most of it squared away already.
[19:05:58] <TheMightyBuzzard> NCommander, weird, yo.
[19:05:45] <TheMightyBuzzard> tos does though
[19:05:10] <NCommander> TheMightyBuzzard, I'm going to glaze right over the new stuff because the old stuff catches my eye
[19:04:46] <TheMightyBuzzard> tng is not correctly collapsing comments on page!=1 though
[19:04:45] <NCommander> TheMightyBuzzard, my issue with making the old comments change color is they pop more than new comments because its a break in the site theme
[19:04:21] <NCommander> TheMightyBuzzard, can't reproduce it now. I'll keep looking
[19:04:08] <NCommander> ah
[19:03:40] <TheMightyBuzzard> oh, i think AC is set to 0:0 on dev
[19:03:24] <NCommander> as AC
[19:03:16] <NCommander> TheMightyBuzzard, loaded 0:0 on Firefox
[19:02:45] <NCommander> So the text remains black but the comment box is different looking
[19:02:31] <NCommander> TheMightyBuzzard, also that grey has to go. My eyes will jump out of my head, drive to TN, and murder you in your sleep :). Maybe instead of grey on grey, we change the red.
[19:02:13] * NCommander fires firefox
[19:02:06] <TheMightyBuzzard> NCommander, oddball behavior. see if you can get it to reproduce like in another browser?
[19:01:30] <NCommander> Initial page load when no comments are read?
[19:01:21] <TheMightyBuzzard> paulej72, correct except for the template hardcoding.
[19:01:21] <NCommander> Worked on second load
[19:01:01] <TheMightyBuzzard> loaded 2:5 for me
[19:00:57] <NCommander> And my scores in preferences are set correctly
[19:00:52] <paulej72> TheMightyBuzzard: IIRC our new code does not work on old stories, correct
[19:00:39] <NCommander> TheMightyBuzzard, yeah
[19:00:36] <TheMightyBuzzard> that link i just sent?
[19:00:12] <NCommander> my preferences are set to 0/4
[19:00:07] <NCommander> TheMightyBuzzard, ... and it loaded with Threshold/Breakthrough == 0
[18:59:24] <aqu4> ^ "3Hang Many Comments Here - Dev.SN"
[18:59:17] <TheMightyBuzzard> try https://dev.soylentnews.org
[18:58:54] <aqu4> ^ "3Latest Performance Report for: https://soylentnews.org | GTmetrix"
[18:58:53] <NCommander> https://gtmetrix.com
[18:58:46] <aqu4> ^ "3Latest Performance Report for: https://dev.soylentnews.org | GTmetrix"
[18:58:45] <NCommander> https://gtmetrix.com
[18:58:35] <NCommander> TheMightyBuzzard, GTMetrix says dev loads faster a second faster on that article
[18:58:24] <TheMightyBuzzard> only stories forward of... um... some time last year will show the real speed improvement.
[18:57:58] <NCommander> TheMightyBuzzard, well I needed an article with real comments :)
[18:57:48] <TheMightyBuzzard> ooooh, that's a 2014 article. it uses old code to pull comments. it should be slow still.
[18:56:28] <NCommander> Ironically, Encounter At Farpoint remains one of my all time favorite episodes though
[18:56:17] * TheMightyBuzzard ponders
[18:56:14] <NCommander> 5-7 were not really up to the same scratch
[18:56:02] <NCommander> It also peaked Season 3/4.
[18:56:00] <TheMightyBuzzard> yup.
[18:55:47] <NCommander> TNG for me just hasn't aged well. I find it less favorably as years go on
[18:55:40] <TheMightyBuzzard> i couldn't dig on the spirituality aspects of it but man did i lurve the klingon bits.
[18:55:26] <NCommander> VOY had some of my favorite episodes, but on the whole it was rather weak.
[18:55:17] <NCommander> TheMightyBuzzard, DS9 is my favorite
[18:55:11] <NCommander> They never made them to it air though
[18:55:06] <TheMightyBuzzard> ya, the first of it was slow. it's prolly my third favorite trek series though
[18:55:01] <NCommander> TheMightyBuzzard, technically the TOS theme had them; Gene Roddenbury included them so he could collect royalties on it and screw the theme writer
[18:54:29] <TheMightyBuzzard> trek songs just should not have words.
[18:54:25] <NCommander> Season 1-2 was crap. Three was OK but fucking slow. I actually enjoyed parts of 4 except "All The Voyages"
[18:54:17] <TheMightyBuzzard> i'll admit, it did make me want to throat punch someone.
[18:54:09] <NCommander> Actually, I didn't mind it
[18:53:51] <TheMightyBuzzard> no lurve for the theme song, eh?
[18:53:34] <NCommander> TheMightyBuzzard, you get banned when Commenting-ENT appears
[18:53:18] <TheMightyBuzzard> i just have that predictable kind of sense of humor
[18:53:02] <NCommander> TheMightyBuzzard, it should still be in the mysql hotcache though
[18:52:56] <TheMightyBuzzard> if we do another, probably
[18:52:29] <TheMightyBuzzard> also has 500m free though.
[18:52:28] <NCommander> (is our next revamp going to be DS9?)
[18:52:18] <NCommander> TheMightyBuzzard, I sorta like having root comments auto-expand, but I am to experiment with it. That might be a good differenation between TNG/TOS
[18:52:13] <TheMightyBuzzard> well it's swapping. that could have something to do with it.
[18:51:42] <TheMightyBuzzard> ahhh, okay.
[18:51:39] <NCommander> TheMightyBuzzard, it might be lithium shitting itself, but dev is loading comments *much* slower for me than prod.
[18:51:02] <NCommander> A comment is *always* folded unless it's >= breakthrough
[18:50:44] <NCommander> Threshold is when a comment is moderated out of existence, and doesn't show up at all aside from the X comments line
[18:50:28] <NCommander> No, you're missing the point
[18:50:21] <TheMightyBuzzard> so you want all root comments expanded is what you're saying?
[18:50:01] <TheMightyBuzzard> they should be collapsed
[18:49:56] <TheMightyBuzzard> nah, search "score: -1"
[18:49:38] <NCommander> TheMightyBuzzard, all the comments on the dev article are expanded for me regardless of breakthrough
[18:49:37] * TheMightyBuzzard scratches his head
[18:49:15] <NCommander> No, comments always start collapsed. With current behavior, they auto-expand if they're a root comment *or* they breakthrough
[18:48:55] <TheMightyBuzzard> is that not what's happening?
[18:48:38] <TheMightyBuzzard> threshold = anything >= this should be shown unless it's in a collapsed tree. breakthrough = show this even if the tree it's in is collapsed.
[18:48:28] <NCommander> (using Chrome timeline to waterfall)
[18:48:20] <NCommander> TheMightyBuzzard, production: 6 seconds to fully load in and DOM complete. Dev is 9
[18:48:05] <NCommander> TheMightyBuzzard, no logged in
[18:47:15] <TheMightyBuzzard> cause ACs get that shiz varnish cached.
[18:47:02] <TheMightyBuzzard> AC?
[18:46:48] <NCommander> TheMightyBuzzard, odd. it loads a LOT faster here
[18:46:41] <aqu4> ^ "3SoylentNews Comments | Unconfirmed Purchase Transaction Reported"
[18:46:34] <NCommander> https://soylentnews.org
[18:46:31] <TheMightyBuzzard> NCommander, over 20s load time for me on prod. 10 on dev.
[18:46:15] <NCommander> TheMightyBuzzard, threshold is when a comment disappears, breakthrough is when it auto-expands. I'm seeing what I expect on production with the same settings
[18:45:47] <aqu4> ^ "3Unconfirmed Purchase Transaction Reported - SoylentNews"
[18:45:38] <NCommander> TheMightyBuzzard, https://soylentnews.org - it loads faster on prod
[18:45:37] <TheMightyBuzzard> no, with the link you gave me: Threshold=0 and Breakthrough=4 most all of them should be expanded.
[18:44:42] <TheMightyBuzzard> that one should load slow with as many comments as it has but i promise you it's a fuckton faster than it would load on prod.
[18:44:16] <TheMightyBuzzard> NCommander, hang tight, lemme check
[18:43:57] <NCommander> TheMightyBuzzard, unless I've gone crazy, with 0/4, the top two comments should be expanded, and the rest below should be collasped
[18:43:02] <aqu4> ^ "3Unconfirmed Purchase Transaction Reported - Dev.SN"
[18:42:55] <NCommander> TheMightyBuzzard, yeah. ALso, nothing is collapsing and I'm getting horridous loading lag: https://dev.soylentnews.org
[18:42:17] <TheMightyBuzzard> mode?>
[18:41:59] <TheMightyBuzzard> saving what?
[18:41:50] <NCommander> TheMightyBuzzard, changing between Threaded-TOS/Threaded-TNG is not reliably saving for me
[18:40:39] <NCommander> TheMightyBuzzard, I'm sorta tempted to reset the dev database with prod
[18:40:31] <NCommander> TheMightyBuzzard, I'm having serious trouble visualizing how this will work on production
[18:40:28] <chromas> that is some dark chocolate, my friend </fake russian accent>
[18:39:01] <NCommander> yay
[18:39:00] * NCommander has chocolate doom cross-compiling
[18:34:51] * TheMightyBuzzard wanders off to have himself a nap
[18:33:58] <aqu4> ^ "3Roll Out The Barrel - YouTube"
[18:33:57] <MrPlow> https://www.youtube.com
[18:33:57] <TheMightyBuzzard> #yt roll out the barrel
[18:33:51] <TheMightyBuzzard> fuck that, we're rolling out the barrel!
[18:33:30] <chromas> fuck that, we're rolling out 12 blades!
[18:33:11] <TheMightyBuzzard> fuck that, we're rolling out this weekend.
[18:32:53] <chromas> You'll have enough months to do it in time ;)
[18:31:56] <TheMightyBuzzard> slightly. we should make paulej72 do it before release.
[18:31:39] <chromas> But then you'd have to make it know where it came from. sounds like work
[18:31:26] <TheMightyBuzzard> oh
[18:31:14] <chromas> Nah, I don't mean the comment folding, just loading the entire set of comments on a story after replying to one that was open alone in a tab
[18:30:25] <TheMightyBuzzard> it only collapses the comments individually not the threads.
[18:30:21] <chromas> I bet that would be lost on people using emojis that face the other way
[18:29:47] <TheMightyBuzzard> me, ima use TNG not TOS
[18:29:06] * TheMightyBuzzard shoots chromas dead 💥🔫
[18:28:57] <chromas> Needs javascript
[18:28:44] <TheMightyBuzzard> ya, it's sposed to.
[18:28:36] <TheMightyBuzzard> but yeah, i can't make it save what you've expanded/shrunk
[18:28:33] <chromas> but then it loads the whole comment thread after
[18:28:24] <chromas> That's what I meant
[18:28:03] <TheMightyBuzzard> ditto replying
[18:27:52] <TheMightyBuzzard> if you wanna moderate something you can click on the comment id and open it in a new tab
[18:26:40] <TheMightyBuzzard> yup, live with it
[18:26:31] * chromas asses up your hard work
[18:26:25] <chromas> So if I wanna comment then I have to reload the whole page
[18:26:10] <chromas> I think comments do the same
[18:26:04] <TheMightyBuzzard> it takes you back same as commenting does
[18:25:56] <TheMightyBuzzard> moderate on the same page.
[18:25:43] <TheMightyBuzzard> oh preserve expansion/collapshion?
[18:25:41] <chromas> Like if I open a comment in a new tab and moderate it, then it loads the whole thread
[18:25:28] <TheMightyBuzzard> hmmm?
[18:25:19] <chromas> It doesn't preserve context though. -1, Disagree
[18:24:25] <TheMightyBuzzard> me too. i'm much proud of pj on that one.
[18:24:00] <janrinok> I like the return to comment after moderation!
[18:23:22] <TheMightyBuzzard> s'a valid point
[18:23:08] <chromas> If you're getting paid, you're a professional. Sweet, you're a pro? Sign me up!
[18:22:08] * TheMightyBuzzard whips up a banner for his amateur breast exams business
[18:20:56] <chromas> Do it. Get those ad impressions!
[18:20:13] <TheMightyBuzzard> we'd need at least 5 pages for every story though.
[18:19:48] <chromas> Yes
[18:19:46] <chromas> or orientated
[18:19:41] <TheMightyBuzzard> Booooobs
[18:19:35] <chromas> It does look pretty good though. I see the chevrons are aligned
[18:19:15] <TheMightyBuzzard> har!
[18:19:00] <chromas> Do it like Google. "Soyyyyyyyyyylent"
[18:18:30] <TheMightyBuzzard> screw conformity!
[18:18:19] <chromas> Or do the classic [First | 1 | Last ] thing
[18:17:53] <TheMightyBuzzard> might add Page: before it
[18:17:48] <chromas> Sure but maybe it could say that's what it is or summin'
[18:17:26] <TheMightyBuzzard> oh, page numbers. i like having 1 even if there's only one page
[18:17:24] janrinok_afk is now known as janrinok
[18:17:17] <chromas> I think it's for Page 1 but it doesn't say so
[18:17:03] <chromas> Just above the top comment
[18:16:44] <TheMightyBuzzard> what (1)?
[18:14:21] <chromas> The "(1)" could maybe use an explanation
[18:13:05] * chromas posts a comment
[18:05:23] <TheMightyBuzzard> mostly the aesthetics. i think it's bug free now.
[18:05:04] <aqu4> ^ "320170215c - Test Story - Please Moderate but Post No Comments - Bifurcation Breadth-First - Dev.SN"
[18:05:00] <TheMightyBuzzard> NCommander, give https://dev.soylentnews.org a look when you have time. need to know if it's aesthetically workable for you and if you can find any bugs.
[18:00:22] <TheMightyBuzzard> okay, it's passing visibility up the thread properly now as far as i can tell.
[17:55:52] <TheMightyBuzzard> boo and yah. i'm not happy with that variable name though
[17:55:07] <TheMightyBuzzard> stupid recursion
[17:41:26] <TheMightyBuzzard> newp, not quite right...
[17:39:51] <TheMightyBuzzard> yep, my turn now
[17:38:44] <Bytram> okay... back in a couple hours or so... good luck!
[17:35:17] <Bytram> and... there is also test_user_0006 (as well as the normal Anonymous Coward) to use, too... test_user_0006 SHOULD be == AC, except is a registered user; rest of user options are strictly default.
[17:32:42] <TheMightyBuzzard> actually, going to have a smoke. i'll ponder on it when i get back.
[17:31:32] <TheMightyBuzzard> going back into the logic to see why breakthrough stopped working
[17:30:19] <Bytram> remember, there are other test stories I put up there like with 200 comments; please don't change 'em, but they may prove helpful in isolating any problems.
[17:28:54] <TheMightyBuzzard> blerg, some broken logic in there somewheres
[17:28:20] <Bytram> okay... I really need to get some food, do some shopping, and then I can get that out of my mind before the snow flies here
[17:27:52] * TheMightyBuzzard scratches his noggin
[17:27:43] <Bytram> there are now 2 *identical* copies of each story, comment-wise... one with "flat" moderation -- i.e. no moderation, and another one you can moderate to your heart's content to compare results
[17:27:28] <Bytram> there are now 2 *identical* copies of each story, comment-wise... one with "flat" moderation -- i.e. no moderation or comments, and another one you can moderate to your heart's content to compare results
[17:26:02] <TheMightyBuzzard> shit, breakthrough didn't
[17:24:36] <aqu4> ^ "320170215d - Test Story - Please Moderate but Post No Comments - Bifurcation Depth-First - Dev.SN"
[17:24:34] <Bytram> and another one for ya: https://dev.soylentnews.org
[17:24:17] <Bytram> 30 of 30!
[17:23:37] <Bytram> 24 of 30
[17:23:35] <aqu4> ^ "320170215c - Test Story - Please Moderate - Bifurcation Breadth-First - Dev.SN"
[17:23:33] <Bytram> TheMightyBuzzard: while this one is being generated, I have this other one ready for you to moderate to your heart's content: https://dev.soylentnews.org
[17:22:53] <Bytram> 14 of 30
[17:22:09] <Bytram> 5 of 30
[17:22:00] <Bytram> okay, now we're cooking
[17:20:37] <Bytram> I forgot to provide nexus/topic
[17:19:30] <Bytram> bah! automation blew up on 4th test story.
[17:14:38] <TheMightyBuzzard> that specific situation is the only one i can think of that i didn't check while building it
[17:14:15] * TheMightyBuzzard chuckles
[17:13:51] <Bytram> that's what I'm getting to... patience!
[17:13:07] <TheMightyBuzzard> the logic in my head says it should but i'm not certain if i did brain to source translation perfectly
[17:12:11] <TheMightyBuzzard> try modding a bottom-level comment up past breakthrough in TOS, i wanna make sure it only completely expands that one branch.
[17:11:02] <Bytram> done!
[17:10:56] <TheMightyBuzzard> ah, roger
[17:10:17] <Bytram> 23 of 30
[17:09:39] <Bytram> 14 of 30 comments posted
[17:09:11] <Bytram> creating a test story, clone of 20170215a; same structure, but intended for folks to be able to moderate (but NOT post comments)
[17:07:59] <Bytram> sry, whayt I meant was, if *I* were coding this, and I had gone through the trouble of uniquely IDing each comment, I'd also uniquely ID each comment tree... while the code was fresh in my mind
[16:46:38] <TheMightyBuzzard> or put in a comment?
[16:46:31] <TheMightyBuzzard> you mean take out the tree_id since it's unused?
[16:46:20] <TheMightyBuzzard> put what in?
[16:44:05] <Bytram> hmmm
[16:43:44] <Bytram> okay... break time, and I still have not had breakfast yet.
[16:43:27] <Bytram> that's something that I would certainly do, just-in-casre
[16:43:11] <Bytram> Imean "you" in the general sense, btw, not YOU
[16:42:57] <Bytram> maybe just for completeness sake? while you're at it, might as well put in while you've got it figured out... rather than try to sort it out and add it in later
[16:42:08] <TheMightyBuzzard> that's prolly why the comment_cid. no idea on the tree_cid
[16:41:50] <Bytram> I think you are right that it might be used as an anchor for returning after post/mod as you said
[16:41:22] <Bytram> hmmm, strange... we go through buncha work to create a unique ID for each comment / tree, but I do not see us using it in the css...
[16:39:54] <TheMightyBuzzard> not entirely sure on that
[16:39:37] <TheMightyBuzzard> except possibly to jump to as an anchor after posting/moderating
[16:38:44] <TheMightyBuzzard> we would if we were writing the css on the fly but we're not.
[16:37:53] <TheMightyBuzzard> ya, i don't think we actually use those for anything.
[16:36:35] <TheMightyBuzzard> in TOS if any child hits Breakthrough, it should be expanded and you should see the subject+etc of all comments directly above it instead of "Comment Below Threshold".
[16:36:12] <Bytram> okay, I'm seeing HTML IDs of: "comment_cid" and "tree_cid"
[16:35:03] <TheMightyBuzzard> and $user->{threshold} and $user->{highlightthresh}
[16:34:22] <TheMightyBuzzard> $comment->{points}
[16:34:04] <TheMightyBuzzard> it's based on the threshold and highlightthresh of the comment and in the case of TOS on the score of comments below it in the thread.
[16:32:48] <Bytram> orly? brb
[16:32:34] <TheMightyBuzzard> none of which uses cid
[16:32:30] <Bytram> undertstood it is css
[16:32:25] <TheMightyBuzzard> well the initial state is set in perl but the hiding showing expanding collapsing is done via css
[16:32:18] <Bytram> just making sure your sib/parent/child exand/collapse/hide/show stuff works; never finished testing that
[16:31:50] <TheMightyBuzzard> that's entirely css
[16:31:44] <TheMightyBuzzard> nope
[16:31:38] <Bytram> also in hide/show expand/collapse comments, right?
[16:31:23] <Bytram> cid is used in dimming, anywhere else?
[16:31:06] <TheMightyBuzzard> hmm?
[16:31:02] <Bytram> well, I never did finish THAT part
[16:30:51] <TheMightyBuzzard> since the last time you tested it i mean
[16:30:49] <Bytram> sod cid is ONLY involved in dimming?
[16:30:39] <Bytram> hmmm, okaaaaaaaaaaay
[16:30:08] <TheMightyBuzzard> don't get too funky with it. we didn't change the comment pulling arranging logic, just the checked or unchecked status of the checkboxes that get styled as chevrons.
[16:29:35] <Bytram> then, do it one more time
[16:29:08] <Bytram> generating another 30 or so comments on a new test story... depth-first bifurcation... make a kid, visit it, make a kid, down to depth==4, and then make sibs on way back up
[16:26:42] <aqu4> ^ "320170215a - Test Story - Please post no comments - Bifurcation Depth-First - Dev.SN"
[16:26:41] <Bytram> see: https://dev.soylentnews.org
[16:26:24] <Bytram> TheMightyBuzzard: Extended copy, preview of text containing <ecode>stuff \n stuff2 \n stuff3 \n ... </ecode> looses line ends after pasting in... sed s/<br>/<br>\n/g
[16:10:46] <TheMightyBuzzard> yarp
[16:10:41] <Bytram> I'm gonna spool up another comment tree and then get some breakfast into me
[16:10:24] <Bytram> okay, I
[16:09:33] <TheMightyBuzzard> which would be gay.
[16:09:16] <Bytram> not much you can do about that, short of having some kind of fade-in
[16:08:56] <Bytram> nod nod
[16:08:35] <Bytram> scroll down to "Comment_0005"
[16:08:27] <TheMightyBuzzard> yup. ditto annoyance if you put in a really long spoiler.
[16:08:16] <aqu4> ^ "320170215a - Test Story - Please post no comments - Bifurcation Breadth-First - Dev.SN"
[16:08:14] <Bytram> load: https://dev.soylentnews.org
[16:07:52] <Bytram> k, when hide/show large comment tree that appears near end of story, browser bounces around and I lost site of the comment I was on ... I know this is not entirely clear, but just putting it out there
[16:07:46] <TheMightyBuzzard> hrm... i should get my personal LE cert updating again some time. haven't configured certbot since switching to Calculate
[16:06:22] <Bytram> understandable
[16:06:11] <TheMightyBuzzard> i likely forgot a lot of what i did monday.
[16:05:53] <Bytram> you're forgiven
[16:04:43] <TheMightyBuzzard> that's how i woulda designed it if i'd thought about it. which i may have done monday and forgotten.
[16:04:09] <TheMightyBuzzard> huh, looks like the lower of Threshold or Breakthrough gets used in TNG. which is fine.
[16:02:21] <Bytram> that was breadth-first; top-level comments first, and then all the kids, and then all grand-kids, and finally all grteat-grand-kids.
[16:01:33] <TheMightyBuzzard> knifety
[16:01:10] <Bytram> each comment has two children, and those have kids, and THOSE have kids
[16:01:05] <TheMightyBuzzard> well i gotta put a few more db update statements in and make sure plain old "Threaded" isn't in the code anywhere anymore but only Threaded showing up in the dropdown box should change.
[16:00:56] <aqu4> ^ "320170215a - Test Story - Please post no comments - Bifurcation Breadth-First - Dev.SN"
[16:00:54] <Bytram> TheMightyBuzzard: have a look-see (no changing, please) at: https://dev.soylentnews.org
[16:00:36] <Bender> woop woop woop (\/) (;,,;) (\/)
[16:00:35] <Bytram> !woop
[15:59:34] <Bytram> k
[15:59:29] <TheMightyBuzzard> nod nod. i'm done unless you find me a bug to fix.
[15:59:25] <Bender> karma - automation: 1
[15:59:25] <Bytram> automation++
[15:59:13] <TheMightyBuzzard> TOS should look/function as much as possible like Improved Threaded
[15:59:11] <Bytram> I'm posting comments atm -- plese do not bounce or otherwise bother dev for a few minutes
[15:59:04] janrinok is now known as janrinok_afk
[15:58:33] <Bytram> k, many thanks!
[15:58:12] <TheMightyBuzzard> Flat, No Comments, Threaded-TNG, Threaded-TOS
[15:57:59] <janrinok> just a thought - I feel that I would prefer (at a much later date!) a single button per story to remove the already shaded comments from the db, i.e. return to a clean story
[15:57:51] <TheMightyBuzzard> i just needed to name Threaded something more descriptive to differentiate it from TNG
[15:57:43] <Bytram> so... what will be in the drop-down... *exactly* ??
[15:57:00] <TheMightyBuzzard> there is literally no code difference between Threaded and Threaded-TNG.
[15:56:28] * Bytram is getting even more and more confuzled
[15:55:53] <TheMightyBuzzard> "Threaded" without a suffix is the same as TNG and thus is going away soon as i write the db statements.
[15:55:22] <janrinok> and switched between all the options without any problems
[15:55:05] <janrinok> I've played with both
[15:54:52] <TheMightyBuzzard> TNG is the one you been playing with for a while now
[15:54:37] <Bytram> urghhhhhhhhhh!
[15:54:30] <TheMightyBuzzard> yup, TOS and TNG are both going live
[15:54:23] <janrinok> I haven't tried all the themes, but I'm sure someone will find a theme in which it doesn't work as well
[15:54:18] <Bytram> wait, we're keeping more than one?
[15:53:58] <Bytram> TheMightyBuzzard: preview in story editor, does not show "[Continues...]" -- only seems to appear when reading the story after it has posted to the site.
[15:53:55] <TheMightyBuzzard> which i gotta rewrite cause now we got two threaded comment modes instead of one.
[15:53:24] <TheMightyBuzzard> but it's linked in the release notes where to turn it off.
[15:53:17] <Bytram> janrinok: ^^ what he said.
[15:53:03] <TheMightyBuzzard> on unless you're AC
[15:52:56] <Bytram> janrinok: off, IIRC
[15:52:35] <janrinok> well, I've not managed to break it yet. I like it very much - but let's see what the community say. Will the dimmed comment default be on or off?
[15:49:48] <Bytram> nod nod
[15:47:34] <TheMightyBuzzard> later though
[15:45:39] <Bytram> brilliant!
[15:44:40] <TheMightyBuzzard> not scriptish, stylish. it's all css
[15:43:53] <TheMightyBuzzard> oooh, i know... i'll do it in scriptish first so it's not actually on ANY server.
[15:43:19] <TheMightyBuzzard> pretty sure i can make an explode button
[15:41:33] <Bytram> nod nod
[15:41:20] <TheMightyBuzzard> ya, it's primary key is (uid, discussion_id)
[15:38:53] <TheMightyBuzzard> yar
[15:38:49] <Bytram> not tried it explicitly, nor even looked, first-things-first
[15:38:09] <TheMightyBuzzard> yup. you've seen it working, no?
[15:37:35] <Bytram> do you know if it works? ;)
[15:37:33] <Bytram> great!
[15:37:03] <TheMightyBuzzard> yup. per uid+story
[15:36:40] <Bytram> you DO keep track of the CID on a per-story basis, right?
[15:34:12] <TheMightyBuzzard> not on a per story basis but yes you can go into prefs and turn it off.
[15:33:44] <Bytram> well, is there a way you can disable dimming after having it enabled? IOW, all-or-nothing, but at least it is something?
[15:33:29] <TheMightyBuzzard> much more efficient but it's limited in utility.
[15:33:13] <TheMightyBuzzard> we'd have to log the read status of every comment for every user. currently we only log the highest cid they've read per story.
[15:32:47] <janrinok> k thanks
[15:32:40] <Bytram> janrinok: excellent question, and to my knowledge, a resounding 'No."
[15:32:37] <TheMightyBuzzard> janrinok, newp. tis beyond our current technical capabilities.
[15:32:19] <Bytram> TheMightyBuzzard: sounds like good practice
[15:32:10] <janrinok> silly question - is there a way of ungreying a greyed out comment at user level? If reading a new comment I might want the previous comment to be highlighted again?
[15:31:32] <TheMightyBuzzard> plus i need to run a test install anyway and chillax is already halfway installed. gonna have to manually run the undone sql commands.
[15:31:29] <Bender> karma - themightybuzzard: 5
[15:31:29] <Bytram> TheMightyBuzzard++
[15:31:22] <Bytram> THAT makes much more sense
[15:30:50] <TheMightyBuzzard> well i was gonna try it on my dev vm first. been working on dev.sn outa sheer lazy.
[15:30:17] * TheMightyBuzzard chuckles
[15:30:14] <Bytram> s/at/and/
[15:30:08] <Bytram> how 'bout you splain here how that would look at work, here, before changing the (hopefully working) code
[15:29:47] <Bytram> ummm, yes and no?
[15:29:09] <TheMightyBuzzard> ya know, i think ima make an explode button for both styles. for to expand+show everything below the comment you click it on.
[15:26:49] <aqu4> ^ "3PLEASE! Read updates in story and check on channel #qa on IRC before making any changes - Dev.SN"
[15:26:48] <Bytram> (2) https://dev.soylentnews.org
[15:26:43] <aqu4> ^ "320170202a - test story for submtting indented comments - Dev.SN"
[15:26:41] <Bytram> (1) https://dev.soylentnews.org
[15:26:38] <Bytram> here are two:
[15:26:36] <TheMightyBuzzard> go with the top one. we monkeyed all over it already.
[15:26:30] <janrinok> or just add a comment to a story and point me at it
[15:26:10] <Bytram> janrinok: yes... just a sec
[15:25:19] <janrinok> Is there a story that I can add a comment to - they all seem to be marked 'do not touch'!
[15:25:00] <Bytram> thas for sure!
[15:23:38] <TheMightyBuzzard> ya know, finished code highs are even better than adderall
[15:22:43] * NCommander vapes contently
[15:22:32] <NCommander> food was tasty
[15:21:54] <Bytram> okay, I think I've got it... give me a few minutes... biab
[15:21:36] <Bytram> agreed, in general, but still not assured to be the case.
[15:20:44] <TheMightyBuzzard> true on prod, less likely on dev
[15:20:26] <Bytram> yes & no; cid *IS* monotonically increasing, but may have sequence gaps from comments that others posted; my comment_nnnn numbers convey slightly different info
[15:19:35] <Bytram> hopefully it speacks better than I do atm!
[15:19:34] <TheMightyBuzzard> thar ya go. cid already takes care of that too.
[15:19:09] <Bytram> hmmm, what to use for a subject for each comment ... that conveys its temporal assignment as well as its logical position? I'm just gonna stick with comment number being temporal and let the structure speack for itself
[15:19:07] <TheMightyBuzzard> gnawed gnawed
[15:18:55] <janrinok> TheMightyBuzzard, I love it! I can see what I've read and what is new!
[15:18:07] <TheMightyBuzzard> go manual. they don't gotta be all that deep.
[15:17:49] <Bytram> not yet
[15:17:47] * TheMightyBuzzard boggles
[15:17:44] <TheMightyBuzzard> you haven't made any?
[15:17:24] <Bytram> hmmm, I need some bifurcating comment trees
[15:17:07] <Bytram> nod nod
[15:16:58] <TheMightyBuzzard> so if they later show up because of subsequent mods, they'll be dimmed.
[15:16:53] <Bytram> need to make that clear in the docs -- set the correct expectations
[15:16:34] <TheMightyBuzzard> yup
[15:16:28] <Bytram> so, it's not so much 'dim already *read* comments' as it is 'dim already loaded/presented comments' ??
[15:16:23] <TheMightyBuzzard> well next time you hit the mark all as read button or hit refresh on the article main page
[15:15:49] <TheMightyBuzzard> they get dimmed
[15:15:17] <Bytram> TheMightyBuzzard: question.... say I load a story with T/B == 5/5 and all comments score, say, 4 or less... *AND* I have pref set to dim already read comments... what happens to those comments, none of which I have actually been able to see?
[15:14:45] <TheMightyBuzzard> deploying fix. be about 30s or so.
[15:14:42] <janrinok> ~gday Bytram
[15:12:50] <Bytram> k
[15:12:36] <TheMightyBuzzard> ya, i'm with ya now
[15:12:22] <Bytram> comment trees currently, and correctly, have "Show/hide comment tree"
[15:12:19] <TheMightyBuzzard> roger
[15:12:15] <TheMightyBuzzard> oh, it's currently show/hide is what you mean
[15:12:02] <Bytram> wait a sec
[15:11:52] <TheMightyBuzzard> okay, show/hide for threads incoming shortly
[15:11:35] <TheMightyBuzzard> yup, i used "> :first-child" instead of "*" like i should have.
[15:11:19] <Bytram> yes, I thought that is what I said?
[15:11:01] <TheMightyBuzzard> i thought we were going with expand/collapse for singles and show/hide for threads
[15:10:51] <Bytram> did you see the spoiler bug I created?
[15:10:18] <Bytram> first thing: need to change the hover text for single comment chvrons: "Expand/collapse comment"
[15:09:54] <TheMightyBuzzard> i bytram'd up a bug in <spoiler> and fixed it too.
[15:09:37] <Bytram> but a BIG snow storm is predicted tomortrow & I need to get groceries & turbo tax, so can't beat on it all day today
[15:09:28] <TheMightyBuzzard> outstandin. that's plenty of debug n tweak time IMO.
[15:09:14] <Bytram> yep, today & tomorrow...
[15:08:53] <TheMightyBuzzard> day off?
[15:08:42] <Bytram> TheMightyBuzzard: okay, I'm poking at "Threaded-TOS"
[15:07:47] <TheMightyBuzzard> i'm kinda thinking i'd like an "Explode" button too that would expand every last comment beneath the current comment but not sure it's entirely necessary
[15:05:18] <TheMightyBuzzard> maybe four, depending.
[15:05:07] <TheMightyBuzzard> feed yoself, hey. we got three days to debug and tweak.
[15:04:08] * NCommander needs food
[14:55:00] <TheMightyBuzzard> i'm akf for a bit now.
[14:54:27] <TheMightyBuzzard> like say someone replied to a troll and got modded up to 5, their post should be breaking through and the parent should be showing its subject but be collapsed
[14:53:00] <TheMightyBuzzard> "comment below threshold" should not however show up on parent comments of comments > breakthrough.
[14:52:00] <TheMightyBuzzard> threshold and breakthrough should both be working
[14:51:12] <TheMightyBuzzard> okay, NCommander, i think TOS is functional. see if you dig it and if you can break it.
[14:26:08] -!- janrinok [janrinok!~janrinok@Soylent/Staff/Editor/janrinok] has joined #dev
[14:26:08] -!- janrinok has quit [Changing host]
[14:26:08] -!- janrinok [janrinok!~janrinok@3x03iz5598mh2r07503n6nplyc38ex3x.ipv2.abo.wanadoo.fr] has joined #dev
[14:23:56] * TheMightyBuzzard ponders
[14:21:09] <TheMightyBuzzard> okay, that's fixed. now i'd like to have the treeshider unchecked if any kids are visible as well
[14:12:43] <TheMightyBuzzard> damn, i broke it worse than i thought.
[14:03:21] <TheMightyBuzzard> hrm, that didn't work. it in fact broke things.
[13:50:24] <TheMightyBuzzard> almost there. need a smoke break though.
[13:42:37] <TheMightyBuzzard> okay, breakthrough is technically working but it's not working correctly. it's breaking through if $comment->{points} >= $user->{threshold}
[13:31:49] <TheMightyBuzzard> yay, better. now i just gotta make the double chevron not checked too
[13:30:33] <TheMightyBuzzard> was checking the wrong var. fixed that and seeing what's what
[13:23:13] <TheMightyBuzzard> ha, got it. now i just gotta figure out how to do it right
[13:22:11] <TheMightyBuzzard> okay, now i gotta find out why $visible ain't getting properly set
[13:20:37] <TheMightyBuzzard> looking forward to being done with this and getting back to MrPlow's rusty code
[13:20:06] <TheMightyBuzzard> yup. it is very handy like that.
[13:19:55] <NCommander> TheMightyBuzzard, and this is why I love rust, because it catches shits like that as a compiler error
[13:19:38] <NCommander> TheMightyBuzzard, I just woke up
[12:57:04] * cmn32480 notes the crickets....
[12:42:05] <TheMightyBuzzard> for those curious it was a using a .= instead of an = when accepting a hashref as a returned value.
[12:33:13] <TheMightyBuzzard> NCommander, paulej72, and this is why i took the day off yesterday. chased a bug for over an hour monday and could not figure out wtf. sit down today fresh and it's fixed in 10m.