#dev | Logs for 2016-02-07
« return
[01:48:52] Bytram|away is now known as Bytram
[04:54:17] Bytram is now known as Bytram|away
[05:58:09] -!- aqu4_ has quit [Ping timeout: 268 seconds]
[05:58:09] -!- aqu4 has quit [Ping timeout: 268 seconds]
[06:23:30] -!- aqu4 [aqu4!~aqu4bot@universe2.us/ircbot/aqu4] has joined #dev
[06:23:30] -!- Subsentient [Subsentient!~WhiteRat@Soylent/Staff/Editor/Subsentient] has joined #dev
[12:28:51] Bytram|away is now known as Bytram
[13:11:03] <Bytram> TheMightyBuzzard: I'm looking at Data.pm and the ansi_to_utf stuff (around line 1220)... any idea why it uses a numeric literal of 65533 in most places, but a STRING literal of '65533' in others? Better still, this is a case of using a 'magic number' -- wold prefer to see something along the lines of a C CONST where a constant is defined whose *name* tells what it is, and then we use the name instead of the magic number in the code.
[13:11:38] <Bytram> is there a way to canonically define a constant in Perl? or is it just a [global] var one defines somewhere?
[14:55:18] <Bytram> TheMightyBuzzard: I've got a fix pending for bug 253 (Older Stories) and was about to try to create a pull request
[14:55:47] <Bytram> I resynched everything before I started: git checkout master && git pull upstream master && git push origin master
[14:56:04] <Bytram> went to an existing branch: UI_fixes
[14:56:26] <Bytram> changed a file: getOlderStories;misc;default
[14:56:53] <Bytram> then: git status
[14:57:00] <Bytram> which showed a single changed file (mine)
[14:57:09] <Bytram> git commit
[14:57:24] <Bytram> git push origin UI_fixes
[14:57:29] <Bytram> so far so good.
[14:57:49] <Bytram> but, when I go to github: https://github.com
[14:57:50] <aqu4> ^ "3GitHub - marty-b/rehash at UI_fixes: Forked from Slashcode, rehash is the codebase that powers SoylentNews.org, powered by mod_perl 2"
[14:58:10] <Bytram> it says: "This branch is 1 commit ahead, 42 commits behind SoylentNews:master."
[14:58:11] <Bytram> ???
[14:58:38] <Bytram> how can I be 42 commits behind?
[14:59:31] <Bytram> I'm tempted to click 'New pull request' button, but want to make sure all is well before I continue.
[14:59:51] <Bytram> So, do I click the button or do I have some catchup work to do first or... something else?
[15:03:07] <Bytram> hmmm, just realized that there's prolly a path I should have taken starting AT the bug report (#253) instead of trying to link it up after the fact. ??
[15:03:15] <Bytram> anywho, am holding off for now.
[15:03:33] <Bytram> am expecting a phone call so am going offline for a while.
[15:03:40] <Bytram> catch ya all later.
[15:03:45] Bytram is now known as Bytram|away
[16:27:25] Bytram|away is now known as Bytram
[20:06:11] Bytram is now known as Bytram|away
[23:02:12] Bytram|away is now known as Bytram