#dev | Logs for 2019-01-22

« return
[15:19:22] <Bytram> Ruh Roh!
[15:19:24] <Bytram> https://soylentnews.org
[15:19:27] <exec> └─ 13World's Top 26 Billionaires Now Own as Much as the Poorest 3.8 Billion - SoylentNews
[15:20:01] <Bytram> Looks like there's an unclosed "<s>" in a comment that is flowing through to subsequent comments.
[15:20:08] <Bytram> https://soylentnews.org
[15:20:10] <exec> └─ 13SoylentNews Comments | World's Top 26 Billionaires Now Own as Much as the Poorest 3.8 Billion
[15:20:47] <Bytram> https://developer.mozilla.org
[15:25:32] <Bytram> comment_text.790018 was: <p><s>But think how much wealth was created by those 26 people - they _deserve_ all those billions</s></p>
[15:25:39] <Bytram> changed to: <p><sarcasm>But think how much wealth was created by those 26 people - they _deserve_ all those billions</sarcasm></p>
[15:26:50] <Bytram> ugh... there are other comments below it which also have <s> tags;
[15:27:02] <Bytram> TheMightyBuzzard: you around? Looks like we need a css fix?
[15:28:34] <Bytram> We can wack-a-mole use of <s> in comments, but it really needs a permanent fix.
[15:30:58] <Bytram> https://soylentnews.org
[15:34:06] <Bytram> looks like it is an issue with definition of ".commentDiv" on line 18 of https://soylentnews.org
[15:41:10] <Bytram> Xyem: fyngyrz: SemperOSS: NCommander: Any of you around?
[15:41:20] <Xyem> Hey
[15:41:25] <Bytram> hi!!!!
[15:41:31] <Xyem> How can I be of service?
[15:41:38] <Bytram> got an issue with an unclosed <s> tag in aa comment
[15:41:46] <Bytram> so,illing into subsquent comments
[15:41:52] <Bytram> *spilling
[15:42:00] <Bytram> do you know where the .css files are kept?
[15:42:19] <Bytram> see: https://soylentnews.org
[15:42:22] <Bytram> and following
[15:42:23] <exec> └─ 13SoylentNews Comments | World's Top 26 Billionaires Now Own as Much as the Poorest 3.8 Billion
[15:48:21] <Bytram> ahhh, found fluorine has /usr/local/slash
[15:49:31] <Xyem> Ah.. I didn't realise I had any access to production
[15:50:02] <Xyem> Planning on removing the strikethrough formatting globally as a workaround?
[15:50:03] <Bytram> Looks like this is the place:
[15:50:04] <Bytram> martyb@fluorine:/usr/local/slash/themes/slashcode/htdocs$
[15:50:35] <Bytram> se4eing if there is a way to add a rule so that the end of .commentDiv causes <s> to be termnated.
[15:53:42] <Xyem> I'd be surprised if CSS can help with that. The HTML isn't valid
[15:55:26] <Bytram> div.commentDiv + * {text-decoration: none}
[15:56:10] * Bytram has enough knowledge of css to do a bunch of things, but doesn't have all the corner cases sorted out.
[15:57:10] <Xyem> That makes it continue over the buttons, but not into the next comment
[15:57:25] <Bytram> yep
[15:57:39] <Bytram> hmmm
[15:57:43] <Bytram> !!
[15:57:52] <Bytram> div.commentDiv {text-decoration: none}
[15:58:10] <Bytram> that turns off the strikethrough in the comment div...
[15:58:22] <Bytram> will that carry through the rest of the comments on that page?
[15:58:49] <Bytram> yeah, FAR from optimal.
[15:59:32] <Bytram> hrmmm, I have an idea
[16:00:10] <Bytram> give a *parent* entity the {text-decoration: none}
[16:00:19] <Bytram> parent to .commentDiv
[16:00:27] <Bytram> would that work?
[16:00:53] <Xyem> As far I know, you can't "select the parent" with CSS.. but my CSS knowledge is lacking
[16:01:19] <Bytram> I'm weak there, too.
[16:04:17] <Bytram> biab
[16:07:38] <Bytram> back
[16:08:09] <Xyem> Welcome back
[16:08:34] <Bytram> think I found *a* place... ./themes/default/htdocs/comments.cssraw:.commentDiv{
[16:10:50] <Bytram> nope
[16:14:15] <Bytram> site var: approvedtags value: b|i|p|br|a|ol|ul|li|dl|dt|dd|em|strong|tt|blockquote|div|ecode|quote|sup|sub|abbr|sarc|sarcasm|user|spoiler|del|s|strike
[16:14:36] <Xyem> Is it not:
[16:14:41] <Xyem> /srv/soylentnews.org/rehash/site/soylent-mainpage/htdocs/base.css
[16:15:02] <Bytram> on fluorine?
[16:16:17] <Bytram> looks like that is it on fluorine
[16:16:20] <Bytram> dang.
[16:16:27] <Bytram> I really gtg
[16:17:08] <Bytram> quick and dirty workaround? remove "del|s|strike" from the approvedtags site var
[16:17:15] <Bytram> Xyem: thoughts?
[16:17:37] <Xyem> If that would cause it to be escaped before rendering out to the clients, sounds like a good idea to me
[16:17:59] <Bytram> not sure, but IIUC, it would block users from using it for the time being.
[16:18:09] <Bytram> o/w word will get out and trolls could have a field day.
[16:18:24] <Bytram> we can add it back in later, once we have .css fixed.
[16:18:37] <Bytram> assuming that does what I expect, of course
[16:19:11] <Bytram> unless you have a good reason not to, I think I'm going to try it. Is easy to undo, at least.
[16:19:43] <Bytram> ugh,
[16:20:12] <Bytram> went to try it on dev and got: Forbidden /n You don't have permission to access /index.pl on this server
[16:20:21] <Bytram> for https://dev.soylentnews.org
[16:20:24] <exec> └─ 13403 Forbidden
[16:20:29] <Bytram> yep
[16:20:46] <Bytram> okay, I saved the change to the site var.
[16:21:19] <Bytram> nope.
[16:21:31] <Bytram> oh, need to bounce the server?
[16:22:13] <Xyem> Yes. I redeployed rehash on dev and that's back up now (in some state..)
[16:22:20] <Bytram> oh, nice
[16:22:41] <Bytram> just did: /home/bob/bin/bounce on hydrogen and lithium
[16:22:52] <Bytram> don't know if there are other places it needs to be run?
[16:24:11] <Bytram> didn't work; still allowed to use "<s>" in a comment.
[16:24:13] <Bytram> :(
[16:24:17] <Bytram> restoring site var
[16:25:00] <Bytram> restored allowedtags site var on prod.
[16:25:24] <Bytram> location: https://soylentnews.org > CONFIG > Vars
[16:25:27] <exec> └─ 13- SoylentNews User
[16:25:34] <Bytram> okay, I *really* gtg
[16:25:43] <Bytram> wish I could be more help!!!!!
[16:30:23] <Xyem> I don't believe I have any permissions on production so I can't be of further use as far as I know..
[16:32:38] <Bytram> ummm, I think TMB may have fixed that.
[16:32:51] <Bytram> try doing a kinit and see if you can wander around
[16:33:11] <Bytram> just pushed out a quick story cause the story queue was empty, but I really gtg
[16:58:31] * TheMightyBuzzard yawns
[16:58:31] * MrPlow flips a Skittle into TheMightyBuzzard's gaping mouth
[17:00:02] <TheMightyBuzzard> Bytram, Xyem, it'll take a code change not just a site var change to fix. <s> tags can be disabled in the vars table though if you bounce *both* web frontends.
[17:03:10] <Xyem> We were just looking at workarounds
[17:03:53] <Xyem> Also, good day to you!
[17:04:52] * TheMightyBuzzard waves
[17:05:13] <TheMightyBuzzard> well crap. apparently approved_tags works on input not output.
[17:06:32] <TheMightyBuzzard> workaround is manual db editing in this case looks like
[17:11:49] <TheMightyBuzzard> https://soylentnews.org
[17:11:52] <exec> └─ 13World's Top 26 Billionaires Now Own as Much as the Poorest 3.8 Billion - SoylentNews
[17:13:32] <TheMightyBuzzard> okay, unless folks have been monkeying with it elsewhere and it's in need of fixing, i'm back out for a bit.
[19:47:32] <Bytram> TheMightyBuzzard: thanks for taking care of this! Thanks for confirming a coding change would be required. I did a DB update for comment_text.id=790018 and replaced "<s>" with "<sarcasm>" and "</s>" with "</sarcasm>" (as was the apparent initial intent for that comment.
[19:48:23] <Bytram> When other comments also had issues, I realized I was entering wack-a-mole territory and immediately started looking for a more general solution.
[20:07:40] <chromas> I'd think that'd be something the tag balancer should take care of
[20:08:19] <chromas> Or the browser. It's the browser's responsibility to fix it or throw an error. WONTFIX NOTOURPROBLEM