#dev | Logs for 2018-04-02
« return
[01:32:18] * fyngyrz waiting for TMB to return
[01:36:00] <Bytram> fyngyrz: what are you waiting for?
[01:37:00] <fyngyrz> I did some work on the FAQ page; I asked TMB if I'd managed the pull request such that it go to the main project. He said he was off site, and would answer when he got back
[01:37:41] <fyngyrz> Trying to (a) help and (b) wrap my head around how the collaboration process works.
[01:38:02] <Bytram> ahhh, nod nod
[01:38:16] <Bytram> do you remember which pull request it was?
[01:38:24] * Bytram seems to recall seeing an e-mail about it
[01:39:00] <fyngyrz> well, see, that's the thing. I forked the repo, made the changes, submitted the pull request... but it's unclear to me how, or if, that got over to the actual rehash project
[01:39:02] <Bytram> hmmm, was it this one: #437
[01:39:03] <Bytram> Minor sentence structure repair for "Why is your grammar/spelling so bad?"
[01:39:03] <Bytram> FAQ disclosure of admin-visible IP hashing and consequences WRT apparent anonymity.
[01:39:25] <fyngyrz> no. Hang on, I'll give you a link to my repo
[01:39:53] <Bytram> not necessary
[01:39:56] <fyngyrz> https://github.com
[01:40:15] <fyngyrz> The most recent action, visible at the top, that's the one
[01:40:22] <Bytram> that was the most recent e-mail I've seen that seems vaguely apropos to what you were referencing and that had been puled and merged
[01:40:26] <Bytram> clicky
[01:40:39] <fyngyrz> yes. I did it once and it worked. This is the second time
[01:40:44] <fyngyrz> so there's another lurking
[01:41:11] <Bytram> okaaaay, the top one is pull request #437 -- that's the same one I was referencing
[01:41:29] <fyngyrz> This time, I added page-local link targets so that when someone asks something that the FAQ answers, we can point them specifically to the relevant FAQ item
[01:41:56] <fyngyrz> hmm
[01:42:02] <fyngyrz> okay, lemme go dig around
[01:42:26] <Bytram> yep... clicky on that pull request and it has the same description that I just posted here
[01:43:03] <fyngyrz> no, not seeing it
[01:43:59] <fyngyrz> nope. Not #437
[01:44:03] <Bytram> k
[01:44:42] <fyngyrz> Here: https://github.com
[01:46:36] <fyngyrz> I think I did it wrong, because I'm not seeing anything that lets the actual root rehash project know about this. Hence my original question to TheMightyBuzzard
[01:46:47] <TheMightyBuzzard> fyngyrz, when you make a pull request it shows up to maintainers of the primary repo. then we review it and either merge it or ask for further changes.
[01:46:51] <Bytram> ahh, I see. To my eye, that one is not yet into the master. btw, how did you implement the 'name'? as a name attribute on the anchor element or as an id attribute?
[01:47:03] <fyngyrz> I've used Github for my own stuff quite a bit, but this is my first foray into collaboration
[01:47:39] <Bytram> <a href="..." id="abc"> ... </a> OR <a href="..." name="def"> ... </a>
[01:47:57] <TheMightyBuzzard> no, there are no pull requests to SoylentNews Master
[01:47:59] <fyngyrz> <a name-"foo"></a>[#foo]
[01:48:07] <Bytram> okaaay
[01:48:08] <fyngyrz> hmm. Then I screwed it up
[01:48:13] <TheMightyBuzzard> need to set that when you create the pull request
[01:48:28] <Bytram> I thought I read somewhere that the name attribute was deprecated for HTML5?
[01:48:43] <Bytram> was quite a while ago, so that may no longer be the casre
[01:48:44] <TheMightyBuzzard> well not usually but you at least need to check that's where it's merging to.
[01:48:47] <Bytram> *case
[01:48:53] <fyngyrz> figures. They're constantly screwing HTML up
[01:49:15] <fyngyrz> ios the site HTML5?
[01:49:26] <fyngyrz> s/ios/is/
[01:49:30] * TheMightyBuzzard chuckles
[01:49:42] <TheMightyBuzzard> it's whatever the hell we feel like using at the time
[01:49:50] <fyngyrz> okay then :)
[01:50:19] <TheMightyBuzzard> there are some that think we should pick a standard and stick to it but they're heretics
[01:51:03] <fyngyrz> I have an entire rant on "deprecated" being a cognitive error
[01:51:24] * Bytram remembers the 'joys' of the devs trying to bludgeon way-too-old version of mod_perl and apache into a working state... tries to use the newest, backwards-compatible constructs as a vested self-interest in having as few problems in the future as possible
[01:51:38] <fyngyrz> So, TMB, how do I get this to rehash now?
[01:51:52] <TheMightyBuzzard> kill that pull request and make another
[01:53:22] <fyngyrz> um... there's a fair bit of work went into that.... looking to see if I can copy/paste it out
[01:53:57] <TheMightyBuzzard> no, just delete the pull request not the branch
[01:54:09] <TheMightyBuzzard> or rather close i think is the term
[01:54:27] <TheMightyBuzzard> then you can make another pull request from that branch and not lose anything
[01:54:40] <fyngyrz> it's not merged
[01:54:55] <TheMightyBuzzard> um...
[01:55:11] <fyngyrz> sorry, all new to me, duh
[01:55:19] <TheMightyBuzzard> it doesn't need to be merged. that branch just has to have all the stuff you want changed done in it.
[01:55:38] <fyngyrz> doesn't tht only exist in the pull request?
[01:55:53] <TheMightyBuzzard> you make a branch from master, change stuff, then make a pull request to our repo.
[01:56:08] <TheMightyBuzzard> naw. it exists in the branch or you couldn't make the pull request.
[01:57:06] <TheMightyBuzzard> nothing should ever merge into your master. you just occasionally update it by pulling from ours.
[01:58:11] <TheMightyBuzzard> i'm tired as hell though. if you want i can walk you through the whole process tomorrow.
[01:58:41] <fyngyrz> yes, tomorrow is fine. I've finally found how to see the whole page with changes and have backed the work off
[01:58:53] <fyngyrz> thanks
[01:59:11] <TheMightyBuzzard> no prollem. always glad to help make less work for me.
[02:01:18] <fyngyrz> I'd like to help for sure, but o boy, most def need to grok the process before anything serious goes on
[02:02:39] <Bytram> I've been hand-held through it a couple times, but the mystery-meat navigation of github's GUI is not terribly helpful
[02:02:41] <Bytram> CLI++
[02:02:41] <Bender> karma - cli: 1
[02:04:44] <fyngyrz> I know github as far as working on my own stuff goes. But cross pollination of another project is manifestly unclear to me
[02:04:54] <fyngyrz> I use git here too
[02:05:01] <fyngyrz> I mean, locally
[02:05:30] <fyngyrz> But historically, I've either been the boss, or the only dev
[02:05:36] <TheMightyBuzzard> nod nod
[02:06:08] <fyngyrz> last time, I did it right. This time... I only *thought* I did it right :)
[02:06:39] <TheMightyBuzzard> s'all good. does it look like the changes are in the branch on github or just locally?
[02:06:58] <fyngyrz> anyway, tomorrow will be fine. I look forward to learning how it's done, and I'm going to capture the chat so I have it for reference
[02:07:09] <TheMightyBuzzard> yar, sounds good. ima go smoke then sleep then.
[02:07:14] <fyngyrz> it's on github; I didn't bring the repo home
[02:07:18] <Bytram> ~gnight TheMightyBuzzard
[02:07:18] <fyngyrz> nite!