#dev | Logs for 2017-06-01
« return
[11:13:11] -!- cosurgi [cosurgi!~cosurgi@qylizv7.bl.pg.gda.pl] has joined #dev
[11:13:26] -!- cosurgi has quit [Changing host]
[11:13:26] -!- cosurgi [cosurgi!~cosurgi@Soylent/Staff/Misc/cosurgi] has joined #dev
[14:59:27] <FatPhil> Ug, SN's HTML is very very very broken. Horror big job fixing it, but it's monkey work, so can probably be done bit by bit.
[14:59:54] <FatPhil> To whom should I email a patchset, once I've got bored of monkey-work?
[15:00:35] <FatPhil> I guess I could just use github, but I think github's a bit pants.
[15:02:01] <FatPhil> Jeebus, repo's too big, takes my 15 year old machine quite a while to scan for diffs :(
[15:02:27] <Bytram> FatPhil: AFAIK, github is the way to go... check with tmb or pj to make sure.
[15:03:07] <Xyem> FatPhil: Don't bother with the HTML for the purchase subscription box, I've already changed it
[15:04:29] <Bytram> oh, and btw...
[15:04:34] <Bytram> FatPhil: Hi!
[15:04:37] <Bytram> Xyem: Howdy!
[15:04:43] <Xyem> Afternoon :)
[15:05:59] <Xyem> How're you doing today?
[15:06:24] <FatPhil> I did finally start using github about 2 months ago. Didn't kill me.
[15:07:19] <Bytram> mystery meat navigation :P
[15:07:33] <TheMightyBuzzard> FatPhil, try not to tweak more than ten files per pull request and use a different branch for each pull request. it saves everyone+dog headaches.
[15:08:01] <TheMightyBuzzard> but yes, github definitely preferred to a diff patch.
[15:08:03] <Bytram> a little under the weather, literally... seems like it has rained nearly every day for a month -- hasn't really, but it does FEEL like that.
[15:08:39] <FatPhil> Xyem - are your changes visible somewhere?
[15:08:44] <FatPhil> I'll use github...
[15:09:23] <Xyem> TheMightyBuzzard: Would you mind checking the behaviour of the "purchase subscription" box on dev and let me know if the behaviour is acceptable?
[15:09:39] <Xyem> If so, I will get the code to where I am happy with it and PR it.
[15:10:09] <TheMightyBuzzard> Xyem, anonymous or logged in?
[15:10:28] <Xyem> TheMightyBuzzard: They are both changed.
[15:11:35] <FatPhil> TMB: one thing I've learnt from current work is to keep merge requests small, as someone always has an issue with one of the patches, and that blocks the whole request.
[15:12:10] <TheMightyBuzzard> FatPhil, ya, plus it can lead to having to manually merge huge change sets.
[15:13:24] <FatPhil> I always rebase
[15:13:42] <TheMightyBuzzard> Xyem, i don't have any objections but every time we have disappearing/reappearing blocks, someone bitches.
[15:14:22] <FatPhil> I've been a linux kernel dev & maintainer. It's always dev's job to make sure merges cleanly apply (as fast forwards).
[15:14:32] <Bytram> Huh? "disappearing/reappearing blocks" what is appearing/disappearing?
[15:14:54] <TheMightyBuzzard> Bytram, change the selector from buying for yourself to buying for a uid
[15:15:26] <Bytram> ahhh, hmmm. /me has to take a look.... is it on dev?
[15:15:30] <TheMightyBuzzard> ya
[15:15:44] <Bytram> k
[15:17:13] <Bytram> agreed... is a bit confusing....
[15:19:07] <Bytram> Thinking off the top of my increasingly balding head.... I would prefer having separate 'blocks': (1) "Purchase Subscription for Yourself" and (2) "Purchase Gift Subscription"... with a separate "Continue" button in each 'block'
[15:20:26] <TheMightyBuzzard> #smake Bytram
[15:20:26] * MrPlow smakes Bytram upside the head with a small trouser trout
[15:20:37] <TheMightyBuzzard> don't make me have to change logic that works
[15:21:13] <Bytram> lol
[15:22:03] <TheMightyBuzzard> seriously. that would require two forms and two separate logic chains.
[15:22:30] <Bytram> As UI elements go, I prefer the use of dimming to present something that is there, but not available atm, based on some other selector that is present on the UI
[15:23:16] <TheMightyBuzzard> anyway, i gots a belly overfull of biscuits and gravy. gonna take a nap until i can move again.
[15:23:45] <Bytram> TheMightyBuzzard: sounds decadent.... btw, how's the cold?
[15:23:52] * Bytram hopes you are feeling better!
[15:24:01] <TheMightyBuzzard> all good there. just allergies now.
[15:24:11] <Bytram> allergies-- I hear ya on that one!
[15:24:11] <Bender> karma - allergies: -2
[15:24:24] <Bytram> glad to hear you are feeling better!
[15:25:03] * Bytram just noticed his SN sub expired on 2017-03-01 +(
[15:25:38] * Bytram just granted myself (martyb) 30 days on prod.
[15:26:55] <Bytram> btw, there's a long-standing bug that, if the only subs on a given day are 'grants' (i.e. no $ involved), I get an error e-mail from some daemon whose name escapes me atm. VERY reproducible.
[15:31:57] <Xyem> TheMightyBuzzard: I don't mind making it not "show/hide", if that is preferred.
[15:33:58] <Xyem> That is the reason why I was asking for it to be checked first. No point me getting the HTML to something I'm happy with, with that functionality, if only to remove it :)
[15:41:19] <FatPhil> Let's see if this works: https://github.com
[15:42:05] <FatPhil> github's even worse than gitlab. I'd like an "auto-delete branch upon successful merge" option.
[15:56:42] <Bytram> break time
[15:56:43] <Bytram> afk
[17:17:50] <TheMightyBuzzard> FatPhil, all good. merged.
[17:18:39] <Xyem> TheMightyBuzzard: Do you want me to remove the show/hide?
[17:19:13] <Xyem> Heh, I was about to say "Oh Mighty Buzzard" as a joke, and then remembered that is actually your nickname.
[17:20:08] <TheMightyBuzzard> yeah, I think so. like it or hate it we've got a style everyone is used to and that's outside of it.
[17:21:24] <Xyem> Okay. I'll PR it later.
[17:37:31] -!- cmn32480 [cmn32480!~cmn32480@Soylent/Staff/Editor/cmn32480] has parted #dev
[17:42:10] -!- MrPlow has quit [Quit: Powered by Rust.]
[17:43:04] -!- MrPlow [MrPlow!MrPlow@Soylent/BotArmy] has joined #dev
[17:43:04] -!- MrPlow has quit [Changing host]
[17:43:04] -!- MrPlow [MrPlow!MrPlow@nsa.gov] has joined #dev
[17:47:19] -!- MrPlow has quit [Remote host closed the connection]
[17:47:40] -!- MrPlow [MrPlow!MrPlow@Soylent/BotArmy] has joined #dev
[17:47:40] -!- MrPlow has quit [Changing host]
[17:47:40] -!- MrPlow [MrPlow!MrPlow@nsa.gov] has joined #dev