#dev | Logs for 2017-05-30
« return
[00:14:43] -!- Hera has quit [shutting down]
[00:14:43] -!- Hera [Hera!Hera@dodekatheon.olympus.gr] has joined #dev
[00:14:43] -!- mode/#dev [+o Hera] by ircservices.sylnt.us
[04:42:34] <FatPhil> Bytram: https://soylentnews.org
[04:48:37] <FatPhil> wowsers, just pulled the repo, my codebase was only about a year out of date
[05:07:58] <FatPhil> in the same story, this has the same foe + mods, but is rendered default collapsed: https://soylentnews.org
[05:09:29] <FatPhil> or more specifically is rendered as "Comment below threshold"
[05:11:34] <FatPhil> I'm not sure I even understand the difference between having a comment collapsed, thus non-viewable, and having it "below threshold" and thus non-viewable. That kinda seems like redundancy.
[05:13:44] <FatPhil> maybe a JS-related thing, assuming with JS there's delayed loading of the subtrees?
[05:15:05] <FatPhil> I would suggest that with JS off, there's no need to force the user to go from hidden "below threshold" to hidden collapsed.
[05:44:17] <FatPhil> there's some weird-arse stuff in Comments.pl
[05:49:40] <FatPhil> # Now shit starts getting squirrely.
[05:51:17] <FatPhil> would my $user->{mode} be 'threadtos'?
[05:51:37] <FatPhil> most of what I see in the source implies that
[05:53:44] <FatPhil> oooh, or am I threadtng?
[05:54:07] <FatPhil> now I understand what threadtos was implying!
[05:57:43] <FatPhil> code seems quite keen to use undefined variables, any reason why you do things like: if (!defined($hash->{elem}) || !$hash->{elem}) ... ?
[06:33:20] <FatPhil> what's $pages used for? in one context (New) it's an integer, and in another context (Flat) it's an array hash by the looks of it. And I don't see any relevant users of that value after it's dumped into the hash!
[08:21:22] <Bytram> FatPhil: I should not even be awake at this point, so take the following with a large amount of salt...
[08:22:20] <Bytram> first off -- unless you are doing story editing kinds of stuff no JavaScript is used on the site -- all the hiding/showing/etc. stuff is done strictly with CSS
[08:25:31] <Bytram> next up, I read comments at -1 and have no modifier values for friends/foes/anything, so this is a less tested path through the code.
[08:26:40] <Bytram> but, a quick attempt to reproduce the problem *seems* to show this is a bug.... hmmm.... back in a bit -- I have an idea
[08:27:25] <FatPhil> Is there a dev-writable "play area", as I don't have slash installed on my home server, so can't test any changes I make.
[08:27:53] <Bytram> yes.... https://dev.soylentnews.org
[08:28:22] <Bytram> that is the current 'playground' for devs to try out / test / debug stuff
[08:29:03] <FatPhil> but what's the protocol for actually modifying and testing changes?
[08:29:46] <Bytram> ummm, this is not definitive, k?
[08:30:16] <Bytram> I've been known to try out a thing or two in templates in preparation for passing it on to a dev to make an actual pull request.
[08:30:31] <Bytram> as for actual code?
[08:31:38] <Bytram> Way back when i had a VM and code... I'd make changes in the code and make a pull request... tmb would grab/review/etc. before he would push it to the dev server (IRRC)
[08:31:51] <Bytram> *IIRC
[08:32:37] * Bytram *finally* figured out to mark a nick as a foe
[08:33:27] * Bytram just set jm as a foe and changed modifier for foe to -4
[08:34:21] <Bytram> am now looking at:
[08:34:22] <Bytram> https://soylentnews.org
[08:34:23] <FatPhil> I will admit that I do like the CSS-driven hiding/expanding!
[08:35:02] <Bytram> it is a really creative technique they found to do this...
[08:35:24] <Bytram> gotta say I was impressed to no end that there was a way to do this with CSS
[08:35:56] <Bytram> ahhhh!
[08:36:01] <FatPhil> yup, that's the story URL - #517033 is hidden below threshold, #517045 is visible
[08:36:03] <Bytram> I think I see what is happening
[08:36:42] <Bytram> top-level comments are handled differently than the others... something about their always being displayed, I *think* ...
[08:36:55] <Bytram> lemme see if I can find a test tree on dev that I'd made
[08:37:06] <FatPhil> both those cids are top-level, though
[08:38:32] <Bytram> so they should *always* *display* IIRC
[08:38:53] <FatPhil> Bytram: this looks dodgy: git grep tng
[08:39:21] <FatPhil> $user->{mode} = 'thread-tng' but $mode eq 'threadtng'
[08:40:28] <FatPhil> the hyphenated version is the unique string, so probably wrong
[08:41:02] <FatPhil> but I'm sure that's not the error
[08:41:40] <Bytram> okay... here's a test story with a TLC (Top Level Comment) scored at -1
[08:41:56] <Bytram> I need to make this abundantly clear
[08:42:08] <Bytram> DO NOT CHANGE ANY MODERATION ON THIS STORY, k?
[08:42:12] <Bytram> https://dev.soylentnews.org
[08:42:19] <FatPhil> ack
[08:43:05] <Bytram> nothin against you, but I'd created a couple of test stories with specific moderations at specific levels and someone did some testing and changed things...
[08:43:38] <Bytram> an unmoderated comment is NOT the same as a comment that has been modded up and back down.
[08:44:43] <FatPhil> Oh - Apparently I'm Threaded-TOS
[08:46:28] <FatPhil> Works in TNG
[08:47:12] * Bytram always struggled with the names
[08:47:37] <FatPhil> So it's a threadtos problem, maybe introduced in aee57349f5f97c77b6da4f9cf823f680a8a3d2c4 or before?
[08:47:57] <Bytram> beyond me -- that's a pj or tmb question
[08:48:16] <Bytram> hood on
[08:48:21] <Bytram> hold on
[08:48:38] <FatPhil> I thought you were becoming Mr. Robot, or something!
[08:49:18] <Bytram> Rhttps://dev.soylentnews.org!
[08:49:22] <Bytram> LOL
[08:50:57] <Bytram> I accidentally used "Redundant" instead of "Overrated", but otherwise the scoring is the same... take a look here:
[08:51:09] <Bytram> https://dev.soylentnews.org
[08:51:39] <Bytram> oh, wait.
[08:52:14] <Bytram> that was posted as me... so you'd have to make me a foe and then it gets all weird as I posted *all* the coments to that story
[08:52:21] <Bytram> I have another idea
[08:53:20] <Bytram> am gonna have to check some log files... give me a minute or two
[08:55:53] <Bytram> okay... finally found the right directory!
[08:56:26] <FatPhil> comment 0001 expanded in https://dev.soylentnews.org
[08:58:57] <FatPhil> 0001 and 0005 both expanded in https://dev.soylentnews.org
[09:01:36] <Bytram> hey there buddy... I really want to help ya out here, but I'm just no awake enough to fully concentrate and only happen to be on 'cause i woke in themiddle of thenight and wanted to check out #fite before I went back to sleep.
[09:02:03] <Bytram> I hope I've been able to give you some feedback/help/pointers ??
[09:02:24] <Bytram> either way, I need to go back to bed. I'm back at work in 4 hours.
[09:02:30] <FatPhil> my melatonin pills only put me to sleep for about an hour last night, so I'm a bit of a zombie too.
[09:02:43] <Bytram> nod nod
[09:03:20] <FatPhil> Plenty for TMB to read when he gets here :)
[09:04:10] <Bytram> check the stories on dev going back from now, and You'll see stories that show creating comment trees *AND* specifying moderations *AND* that have nicks like: test_user_0001
[09:05:02] <Bytram> if one of those stories does not suffice, I'm sure you can work out the syntax and I can run a story generation for ya...
[09:05:42] <Bytram> maybe submit a story to dev with what you want run included within <ecode>...</ecode>
[09:05:57] <Bytram> anyway... is back to bed for me.. GOOD LUCK!!!
[12:22:34] <Bytram> TheMightyBuzzard: Hope you are having good luck fixing up your lappy... also, you might want to check out backscroll here. My *guess* is that FP is running into issues wrt a TLC (Top Level Comment), but can't be sure. I've got to head to work, so time to do anything more on it this AM. Hope you can peak at it and maybe sort things out for him?
[12:26:41] <TheMightyBuzzard> FatPhil, Bytram's going to have to figure out how to reproduce the bug or there's very little I can do.
[12:26:57] <Bytram> in that case...
[12:27:28] <TheMightyBuzzard> Bytram, on this bug i explicitly do not need exhaustive edge case testing, i need narrow and specific steps to reproduce at all.
[12:27:36] <Bytram> nod nod
[12:28:28] <Bytram> don't have time to do it now.... really gotta get going for work or will be late, again. :(
[12:28:38] <TheMightyBuzzard> and frankly there's nothing i can do until the middle of next week anyways. got company in from out of state.
[12:29:22] <Bytram> FatPhil: please try and isolate exact details of this bug... comment depth, moderations, user friend/foe settings, etc. Will see if can re-create on dev for ya.
[12:30:00] <Bytram> really gtg
[12:30:04] <Bytram> have a great day everyone!
[21:01:31] <FatPhil> TheMightyBuzzard: I think the URLs posted, at least to me, not logged in, display the bug
[21:02:50] <FatPhil> settings at 3/3 showing a 2 is a bug, and seems 100% reproducable.
[21:03:07] <FatPhil> in TOS, not TNG
[21:04:02] <FatPhil> What's the difference between TOS and TNG apart from workingness? If there's no fundamental difference, why are both supported at all?
[21:19:36] <TheMightyBuzzard> FatPhil, roger. will give it a look when i actually get a chance to sit without interruption.
[21:20:31] <TheMightyBuzzard> tng everything is fully expanded unless it's below the threshold. tos only expands one level deep even if there are +5 comments below.
[21:41:54] <FatPhil> excuse my abruptness - now I am japanese-beer-and-sake-boosted
[21:42:53] <FatPhil> planning meeting for a beer tourism holiday here (i.e. we bring people here), and one of the co-organisers brought a fuckton of shit from .jp with him.
[21:43:10] <FatPhil> So, whilst we were planning, we were drinking.
[21:53:24] <TheMightyBuzzard> damn the rigors of the job
[21:57:41] <FatPhil> I have one job, which is vaguely respectable, but boring
[21:58:57] <FatPhil> I am trying to encourage appreciation of local beer in Estonia.
[21:59:58] <FatPhil> Tonight was a planning a baltic states brewery trip for western-europeans
[22:00:26] <FatPhil> (and one guy from the US will join the trip)
[22:00:49] <FatPhil> (and a new zealander)
[22:01:18] <FatPhil> SHITE! g/f's pouring the rum....
[22:05:04] <TheMightyBuzzard> FatPhil, send me some. i promise to appreciate it.
[22:07:07] <TheMightyBuzzard> the only beer i ever failed to appreciate was when i grabbed a dark, nutty dopplebock after pouring sweat for hours doing yardwork and working up a strong desire for a crisp, refreshing pilsner.
[22:10:02] <FatPhil> that was bad timing
[22:10:22] <FatPhil> now on indian rum and ginger
[22:45:38] <FatPhil> Old Monk ftw
[22:45:47] <FatPhil> night all