#dev | Logs for 2017-05-25
« return
[15:48:58] -!- arti has quit [Excess Flood]
[15:49:03] -!- arti [arti!~arti@162.243.ro.kl] has joined #dev
[19:13:29] <Xyem> Do I have to wait until the big site updates to get things into production, or can small things (like correcting spelling) be done "immediately"?
[19:14:57] <Bytram> what are you looking to change?
[19:15:06] <Bytram> and...
[19:15:13] <Bytram> has it been accepted as a pull request yet?
[19:15:41] <Xyem> I haven't made a PR for it, I just noticed it while I rework the subscribe plugin templates
[19:15:52] <Bytram> ummm
[19:16:04] <Bytram> okay...
[19:16:09] <Xyem> The block title is wrong, it says "Purase Gift Subscription".
[19:16:16] <Xyem> Purcase*
[19:16:18] <Bytram> urgh.
[19:16:28] <Bytram> is that in a template?
[19:16:37] <Bytram> if so, which one?
[19:16:45] <Xyem> Yeah, acsub;subscribe;default
[19:16:51] * Bytram goes to look
[19:16:55] <Xyem> Line 19
[19:17:04] <Bytram> in the middle of something... gimme a minute or two, first. k?
[19:17:26] <Xyem> Heh, no rush.
[19:20:34] <Bytram> and you've made the change in your local code which you will submit for a PR?
[19:21:08] <Xyem> Not yet. I was asking because if it I needed to wait anyway, I was just going to PR all my changes.
[19:21:20] <Xyem> If it can be done right away, I can make one now.
[19:21:31] <Xyem> I'll just give it a quick look over for any others..
[19:21:55] <Bytram> I have the fix pending for the site using the temp[late editor, but I don't want the fix to get lost if it is not in a PR, if you know what I mean?
[19:22:32] <Bytram> I didn't see anything else obviously wrong in my read through of that template.
[19:23:45] <Bytram> brb
[19:24:02] <Xyem> Oh I see. It's changed in mine, so it won't get lost.
[19:24:16] <Xyem> Do you want me to PR it anyway?
[19:25:14] <Bytram> not necessary... just be absolutely sure to submit your change, okay?
[19:25:52] <Bytram> template saved on prod.
[19:25:52] <Xyem> Will do, thanks.
[19:25:58] <Bytram> teamwork++
[19:25:59] <Bender> karma - teamwork: 10
[19:26:12] * Bytram goes to make matching change on dev
[19:26:52] <Bytram> saved
[19:27:35] <Bytram> prolly won't see changes on site until the servers get bounced
[19:28:18] <Xyem> Which will happen shortly as I'm working on it right now :)
[19:29:14] <Xyem> So, I'll probably overwrite your change anyway, right?
[19:29:14] <Bytram> =)
[19:29:19] <Bytram> yep!
[20:13:45] <Bytram> nap time, laters.
[20:15:13] <Xyem> Sleep well.
[22:00:03] <Bytram> I did, thanks!
[22:18:11] <Xyem> Awesome :)
[22:20:31] * Bytram looks at the weather radar and debates whether or not he *really* wants to head out tonight.
[22:22:16] <Bytram> doesn't look too bad -- decides to head out.
[22:36:18] <Xyem> I'll be surprised if these changes are accepted..