#dev | Logs for 2017-03-01

« return
[00:05:57] <paulej72> OK I think I was rembering old code with breakthough being forced to be => than threshold
[00:06:40] <paulej72> can't find it in any of the relevant code, but I still need to check the MySQL.pm
[00:08:15] <TheMightyBuzzard> luck to yas
[00:09:42] <paulej72> nope not there, I guess I was imagining the issues I had the other night
[00:23:28] <TheMightyBuzzard> woohoo!
[00:23:47] <paulej72> l
[00:24:12] <paulej72> did you get it working?
[00:24:49] <TheMightyBuzzard> the flat algorithm? not yet. i was gonna eat first.
[00:24:56] <TheMightyBuzzard> i got distracted and forgot though.
[00:25:02] <paulej72> ok
[00:25:15] <TheMightyBuzzard> i'm gonna make it just pull the direct replies i think
[00:25:16] <paulej72> but at least the error is more sane
[00:25:46] <TheMightyBuzzard> no tree walking. no need to touch the returned array of hashrefs.
[00:26:54] <TheMightyBuzzard> i'll go have a smoke n a cold burrito then unfuck it
[00:44:57] <TheMightyBuzzard> checking the fix then making a pr
[00:46:22] <TheMightyBuzzard> hrm, that didn't work
[00:46:38] <TheMightyBuzzard> it's only giving the one you hit the cid for
[00:47:24] <TheMightyBuzzard> wonder why. i'll check $comments
[00:59:27] <TheMightyBuzzard> okay. current buggery is somewhere in selectCommentsFlat
[00:59:41] <TheMightyBuzzard> and also in printComments
[01:00:08] <TheMightyBuzzard> gonna fix printComments first
[01:01:06] <paulej72> TheMightyBuzzard: i am only getting an error when the page is not the first one
[01:01:19] <TheMightyBuzzard> do huh?
[01:01:57] <TheMightyBuzzard> oh, i fixed it spitting an error to the user. i just gotta make it display all the comments it pulled now instead of just the first one.
[01:03:06] <TheMightyBuzzard> i think you're talking about an entirely different bug
[01:04:25] <paulej72> no i am getting your error when I try to veiw a sing comment in flat mode on page >1
[01:04:48] <TheMightyBuzzard> still?
[01:04:55] <paulej72> yes
[01:04:57] <paulej72> https://dev.soylentnews.org
[01:05:00] <TheMightyBuzzard> fuuuuck
[01:05:01] <exec> └─ 13Dev.SN Comments | 20170228a - PJ's Playground
[01:05:04] <paulej72> my limit is set to 20
[01:05:28] <TheMightyBuzzard> this shit done gone mega-squirrely
[01:05:45] <paulej72> your orderby clause is fucked
[01:07:07] <paulej72> if pages = 1 there is no orderby
[01:07:35] <TheMightyBuzzard> oh, that's fine then
[01:07:45] <TheMightyBuzzard> easy to fix
[01:09:02] <paulej72> but it looks like its not finding the cid. should the limit shit be different if cid is set
[01:09:23] <TheMightyBuzzard> man i ain even know right now.
[01:09:27] <paulej72> its the sikp
[01:10:11] <paulej72> i have 3 comments cid and two children and I am skipping 20 on page 2, 40 on page 3 etc, giveing me 0
[01:11:02] <TheMightyBuzzard> oh, yeah, i get ya. unfortunately i have no idea how to fix it right now. my brain's fucking jello.
[01:11:26] <TheMightyBuzzard> pull it up again, i just made an edit
[01:11:29] <paulej72> I do jsut add && !cid to the line
[01:11:38] <paulej72> if(defined($form->{page}) && $form->{page} > 1 && $form->{page} <= $pages) {
[01:11:47] <TheMightyBuzzard> okey doke
[01:12:18] <paulej72> get rid of the outter if($pages > 1) check as well
[01:12:37] <TheMightyBuzzard> did
[01:12:52] <TheMightyBuzzard> deploying
[01:13:04] <TheMightyBuzzard> still dunno why it ain't showing but one comment
[01:13:17] <TheMightyBuzzard> and the counts in the dropdowns is way off
[01:15:53] <paulej72> is there a conditional around the children?
[01:16:03] <paulej72> in the display?
[01:16:07] <TheMightyBuzzard> screw it man. i'm worthless tonight. if you wanna polish that bug off i'll pr it by 6am tomorrow
[01:16:57] <TheMightyBuzzard> i'll be doing good if i lay down pointing the right way in my bed tonight.
[01:17:00] <paulej72> I'll look a bit
[01:25:39] <paulej72> TheMightyBuzzard:
[01:25:41] <paulej72> if($thread) {
[01:25:41] <paulej72> if(!$args->{cid}) { $html_out .= "<ul id=\"commentlisting\" >$thread</ul>\n"; }
[01:25:41] <paulej72> else { $html_out .= $thread; }
[01:25:41] <paulej72> }
[01:25:58] <paulej72> no that is not it
[01:29:34] <paulej72> $skipped += $comment->{totalvisiblekids} if ($user->{mode} eq 'flat');
[01:30:53] * TheMightyBuzzard shurgs
[01:31:04] <TheMightyBuzzard> possibly
[01:31:28] <paulej72> defintily in displayThread
[01:31:53] <TheMightyBuzzard> well displayThreadNoTemplate more likely
[01:32:26] <TheMightyBuzzard> that's where most of the good stuff happens
[01:41:01] <paulej72> we could just say fuckit an only pull the comment only :)
[01:49:37] <TheMightyBuzzard> we could but i'll be able to figure this out in the morning.
[01:50:11] <paulej72> sure, I just deployed my last pull request to prod
[01:50:19] <TheMightyBuzzard> cool
[01:50:46] <TheMightyBuzzard> ima fuck off and go watch some trek. see ya tomorrow.
[01:51:09] <paulej72> have fun
[03:06:54] <Bytram> hi guys!
[03:07:03] <Bytram> hella job on putting out fires!
[03:07:38] <Bytram> quicky bug report from a user: Reading a story as an AC (NOT logged in), the "Moderate" button *IS* present at the bottom of the page.
[03:07:59] <Bytram> Clicking "Moderate" as an AC causes a KABOOM
[03:08:13] <Bytram> page displays raw HTML -- is not rendered
[03:08:58] <Bytram> tested using: https://soylentnews.org
[03:09:02] <exec> └─ 13New Raspberry Pi Zero with Wireless and Bluetooth - SoylentNews
[03:09:26] <Bytram> Noticed that the single comment present DID NOT have drop-down box for moderation.
[03:09:43] <Bytram> scrolled to bottom of page and saw "Moderate" button WAS displayed
[03:09:59] <Bytram> clicked button. blurg!!
[03:11:14] <Fnord666> is that the technical term?
[03:11:42] <Bytram> It is! (Well, NOW it is. =)
[03:12:08] * Bytram tries to quickly scan scroll back...
[11:59:31] <paulej72> TheMightyBuzzard: tor and content security policy might be having issues
[13:07:24] <TheMightyBuzzard> paulej72, hrm... that's an interesting quandry...
[13:16:06] <TheMightyBuzzard> paulej72, been power-out since like 15m after i woke up. just getting rebooted n started going for the day.
[13:20:16] <TheMightyBuzzard> think ima do some house cleaning before i get going for the day
[13:20:58] <Bytram> Not a huge problem, but there's a bunch of extraneous stuff on the page when I go to print a story... looks like one could block most of the elements with a little CSS. A quick glance suggests that for media==print, using display:none for these: class==nbutton or BUTTON element or DIV class="commentSub" should hit the most of the extra stuff.
[13:23:57] <Bytram> I went to print yesterday's site update story ( https://soylentnews.org ) and the print preview wanted 44 pages for the whole thing. :/
[13:24:08] <exec> └─ 13Site Update: The Next Episode - SoylentNews
[13:24:28] <Bytram> Oh... just figured this one out, too. The print preview contains the text of the linked "Related Stories", too. Prolly want to supress that, too.
[14:43:50] <paulej72> shit who prints out stories
[14:44:19] <paulej72> print.css body{display:none;}
[14:44:23] <paulej72> done
[14:44:33] <paulej72> Bytram: ^^^^
[14:45:10] <paulej72> I have not touched the print.css file ever
[14:46:47] <paulej72> are we even loading the css anymore
[15:37:27] <Bytram> paulej72: Well, I just tried to print out a story so I could see all the issues that were raised in our last Site Update story and to enumerate the changes addressed or that were still open.
[15:38:10] <paulej72> Yeah I know, just trying to be funny
[15:38:30] <paulej72> but anyway, that css does need some lovin
[15:39:09] <Bytram> in print preview I am still seeing: "Reply to This", "Parent", moderation drop-down box, "[Moderate]" button, and some LI bullets displayed between each comment. These take up nearly half of each page to be printed.
[15:39:45] <Bytram> this link has my settings: https://soylentnews.org
[15:39:53] <exec> └─ 13Site Update: The Next Episode - SoylentNews
[15:39:53] <Bytram> print preview on that should make it more apparent.
[15:40:05] <Bytram> and thanks for the funny, too. =)
[15:40:19] * Bytram is a bit wiped out and have a late shift tonight....
[15:40:30] <Bytram> am gonna try and catch a short nap before heading out to work.
[15:40:39] <paulej72> sucks to be you
[15:40:59] <Bytram> barring suprises, I shold leave work at 9:15pm
[15:41:29] <Bytram> oh, and we have a "deep dive visit" today with high-level mucky-mucks touring the store and offering their, umm, feedback.
[15:41:38] <Bytram> oh, and I just pushed out a fresh site update story for today.
[15:41:47] <Bytram> https://soylentnews.org
[15:41:50] <exec> └─ 13Site Update - We're Getting There! - SoylentNews
[15:42:34] <Bytram> do read it, and I meant every word in the intro paragraph -- you and TMB have been doing absolutely AMAZING work pounding this code into shape!!!!!
[15:44:58] <Bytram> paulej72++
[15:44:59] <Bender> karma - paulej72: 12
[15:45:02] <Bytram> TheMightyBuzzard++
[15:45:02] <Bender> karma - themightybuzzard: 9
[16:50:39] <TheMightyBuzzard> paulej72, Bytram, i got fuck-all in the gas tank today. going to take a nap and see if that helps but i wouldn't go holding my breath.
[16:55:47] -!- DECbot [DECbot!~DECbot@90-244-262-780.prtg.in.frontiernet.net] has joined #dev
[16:56:25] <DECbot> Anyone on that can edit the css files?
[16:57:00] <TheMightyBuzzard> DECbot, yeah, sup?
[16:57:59] <TheMightyBuzzard> mind you, if it requires any significant thinking, i am not your man today.
[16:58:21] <DECbot> vt220.css needs the #journal .article h3 a, #journal .article h3 a:visited {} line added for title colors on Journals
[16:58:24] -!- liberza [liberza!~liberza@is.upside.down] has joined #dev
[16:58:59] <DECbot> It is inhereting from base.css, and the gray looks odd.
[17:00:05] <TheMightyBuzzard> ahh, cool. i'll stick it on the to-do list since it's just annoying and not actually breaking stuff. probably get it the same time i go about making the *NEW* thing also brighten title bars.
[17:00:14] <DECbot> probobably something like #jornal .article h3 a, #journal .article h3 a:visited { color: #ffc200; text-decoration: none; } would work
[17:01:07] <TheMightyBuzzard> vt100 probably needs it too i'd expect.
[17:01:27] <TheMightyBuzzard> anyway, thanks for the heads-up
[17:01:56] <DECbot> no problem.
[17:02:26] <DECbot> I can live with it a while if you're too busy, but it looks like it might be an easy fix.
[17:03:58] <TheMightyBuzzard> it is but i'm like three keystrokes of code from complete burnout so i'm gonna have a nap and see what i can get done this afternoon.
[17:04:26] <DECbot> nice.. no hurry. Perhaps like you suggest, when you fiddle with the *NEW* bits.
[17:05:17] <DECbot> Enjoy your nap!
[17:05:25] <TheMightyBuzzard> gracias
[17:05:38] <DECbot> de nada
[18:00:33] <paulej72> DECbot: I can get it tonight.
[20:40:13] <chromas> You can stick an extra class on new comments (class="comment new") and let each theme decide how to mark 'em
[20:45:00] * chromas put a "border-left: soliod 2px #2a2" on the title div; it looks alright.
[21:45:55] -!- aqu4 [aqu4!~aqu4bot@universe2.us/ircbot/aqu4] has joined #dev