#dev | Logs for 2017-02-12
« return
[00:17:45] TheMightyBuzzard is now known as suckitchromas
[00:18:10] suckitchromas is now known as suckitallchromas
[00:18:27] suckitallchromas is now known as damnit
[00:18:40] damnit is now known as TheMightyBuzzard
[07:36:04] -!- crutchy [crutchy!~crutchy@119.17.wmi.rzn] has joined #dev
[08:59:04] -!- crutchy has quit [Quit: Leaving]
[13:58:13] <Bytram> TheMightyBuzzard: paulej72: here's an idea for updating the tooltips for the hide/show controls: "Hide (↑) / Show (↓) -- single comment" "Hide (⇑) / Show (⇓) -- child comments that meet threshold"
[13:58:44] <TheMightyBuzzard> it doesn't do that though
[13:58:55] <TheMightyBuzzard> it hides/shows all comments in the tree
[13:59:15] <Bytram> not if they are below the threshold, we just had that discussion, right?
[13:59:35] <TheMightyBuzzard> no, it hides them beyond collapsed state
[14:00:07] <Bytram> ahhhh, k
[14:00:08] <TheMightyBuzzard> it poof, gone's them
[14:00:36] <Bytram> yep, I get that, now. :/
[14:01:06] <TheMightyBuzzard> i'm confident that folks can figure it out in a few minutes but i'll splain it in the story anyway.
[14:02:15] <Bytram> well, I'll need to ponder some more, but I offer for your consideration using the unicode chars there, all of which are named, too. ↑ ↓ and ⇑ ⇓
[14:02:56] * Bytram goes to clean up and ponder some more... biab
[14:03:17] <Bytram> TheMightyBuzzard: and many thanks for clearing up my misconceptions!
[14:03:23] <TheMightyBuzzard> i'm not sure we could. i know you can reskin a checkbox with images but i dunno about with text
[14:03:54] <Bytram> oh, and for head colds, when I have sinus issues, I find that a big bowl of extra spicy hot-and-sour soup does wonders =)
[14:03:58] <Bytram> hmmm, okay.
[14:04:10] * Bytram goes to ponder even MORE! =
[14:04:12] <Bytram> =)
[14:04:14] <Bytram> afk biab
[14:11:14] <Bytram> show/hide are words that have different meaning in this context; show/hide comment makes the single comment just a title or shows entire comment; show/hide comment tree acutally shows/hides the tree -- suggest for single comment control it should say "Expand/Collapse single comment" or something along those lines
[14:12:02] <Bytram> okay, this time for sure. afk biab
[14:24:43] <TheMightyBuzzard> Bytram, yeah, i was thinking the exact same thing.
[14:25:14] <TheMightyBuzzard> those are the terms i'm using in the site update story anyway.
[14:31:05] <Bytram> great minds think alike, eh?
[14:33:45] <Bytram> What you ran into confirms something I've been doing for a long time; write the user-facing specs, and then write the code to do that... can't tell you how many things become clear when I try to explain them to someone else. Examples are KEY. Like what you did on the API specs. Also, has the benefit of having ready-made test cases to make sure I'm doing what I thought I was! =)
[14:34:49] <Bytram> if I provide an example of each parameter and its possible values, well, that's better than half the battle! =)
[14:35:32] <Bytram> oh, and the nice thing about that choice of words is that each of them has a unique first letter 'H'ide, 'S'how, 'E'xpand, 'C'ollapse
[14:37:20] <Bytram> one other thing, now that the breakthrough test and control are gone; could we PLEASE add a label to the other two drop downs? So we would have: "Threshold: [---v] Mode: [---v] Sort: [---v]"
[14:38:58] <TheMightyBuzzard> maybe
[14:39:16] <TheMightyBuzzard> i'd like to have Breakthrough back though if we can figure out how to do it.
[14:46:57] <Bytram> sadly, I never did quite entirely get my brain around breakthrough... I *think* the idea was that if a "highly-rated" comment happened to appear as a reply to a comment that would otherwise not display because it did not meet one's threshold, the breakthrough specified a score which would allow the comment to appear, anyway.
[14:49:44] <Bytram> So, if Comment_0001 (Score 1) has child, Comment_0002 (Score 0), which itself has a child, Comment_0003 (Score 1).... and I set the threshold == 1, then Comment_0003 would not display, because it was 'under' Comment_0002 which did not meet the threshold; breakthrough == 1 would override that behavior and make it "break through" that limitation.
[14:58:27] -!- janrinok [janrinok!~janrinok@Soylent/Staff/Editor/janrinok] has joined #dev
[15:15:59] <TheMightyBuzzard> yeah, that's how i think it should work at least
[18:48:00] <paulej72> we have too few comments for this to work. you would end up with no comments being shown as the top level comments may not be above you threshold and now you decided to not show its children
[18:48:45] <paulej72> the corrent method show any comment that is above your threshold no matter its location. You can then decide if you wnat to read its partnt if it is not already shown
[18:48:46] <TheMightyBuzzard> entirely possible, yeah
[18:49:17] <paulej72> current not corrent
[18:49:52] <TheMightyBuzzard> i may poke at it a few months from now but it's not at the top of my todo list
[18:49:52] <paulej72> I think wahat we have now is better than the old metonds
[18:50:22] <paulej72> just need to add the js to open all child comments
[18:50:48] <TheMightyBuzzard> yup, i agree. not everyone will though and if it don't cost anything but a week of me going "fucking css bullshit!" and an extra setting, meh.
[18:51:07] <TheMightyBuzzard> NO JS!!!!
[18:51:34] <paulej72> cant be done with css as the differnt contols will fight each other
[18:51:39] <paulej72> $(document).ready(function(){
[18:51:39] <paulej72> $(".childCommentHider:checkbox").click(
[18:51:39] <paulej72> function() {
[18:51:39] <paulej72> $(this).siblings("ul").find('.commentHider:checkbox').attr('checked', this.checked);
[18:51:39] <paulej72> }
[18:51:40] <paulej72> );
[18:51:42] <paulej72> });
[18:51:43] <TheMightyBuzzard> !important
[18:52:15] <TheMightyBuzzard> just make the third button !important so if you click it it overrides what behavior is already happening.
[18:52:29] <paulej72> no it will still fight each other. If I open all chendren with a css based setting, I will not be able to close it with the individual contols
[18:52:44] <TheMightyBuzzard> yup. i'm okay with that.
[18:52:51] <paulej72> I am not
[18:52:55] <TheMightyBuzzard> hrm
[18:53:27] <paulej72> people will bitch that the controls do not work.
[18:53:57] <TheMightyBuzzard> make it a force-explode-all || do nothing button then
[18:54:25] <TheMightyBuzzard> one position expands all comments below this one, the other removes that styling.
[18:54:32] <paulej72> can't be done
[18:54:38] <TheMightyBuzzard> ya reckon?
[18:54:43] <paulej72> othter than JS
[18:55:22] <TheMightyBuzzard> i'm bloody well gonna make sure it's impossible before i give up
[18:55:35] * TheMightyBuzzard has not yet begun to cuss css
[18:55:38] <paulej72> be my guest
[18:57:00] <TheMightyBuzzard> if you wanna do up the js version first and only have the control show when js is enabled, more power to ya. i'm not giving up on a css version yet though.
[18:58:35] <TheMightyBuzzard> oh, hey, did i miss anything in the release announcement?
[18:59:38] <paulej72> I read through it, but i can't be sure if you did
[19:05:41] <TheMightyBuzzard> well i wrote it with a head cold, so i find something new every time i reread it.
[19:52:27] -!- janrinok has quit [Quit: Leaving]
[22:09:04] <TheMightyBuzzard> paulej72, you're right about breakthrough. it does absolutely nothing if comment trees aren't collapsed. i just forgot what with this cold filling my head full of exciting new rocks. fixed the story to reflect that.
[22:38:52] <paulej72> We are not planning on putting out the story yet are we? I think we should make sure we are OK with eveything first. I can do the update next Satureday which we should post as an outage.
[22:40:23] <TheMightyBuzzard> paulej72, not until you get the update live
[22:40:45] <TheMightyBuzzard> it's not set to go out until a year from now, so...
[22:41:57] <paulej72> ok I see, i saw monday not realixing our code takes a dump with dates like that
[22:47:38] <TheMightyBuzzard> yeah, it spooked the eds too. i did have a laugh.
[22:47:58] <TheMightyBuzzard> aight, got brauts about to go on the grill. i'm out until after eating and cleanup.