#dev | Logs for 2014-12-02
« return
[13:48:46] <paulej72> TheMightyBuzzard: are you here?
[13:48:53] <TheMightyBuzzard> yep
[13:48:55] <TheMightyBuzzard> sup?
[13:49:11] <paulej72> looking at your pull requests.
[13:49:23] <TheMightyBuzzard> big one giving you fits?
[13:50:34] <paulej72> first question: with the fliters in constants.pm the values of the filters I think are related to whether an admin or regular user can access them, do you know if this is the case
[13:51:58] <TheMightyBuzzard> haven't looked at constants.pm but what a filter does is hardcoded in Data.pm and not seclevel sensitive.
[13:52:30] <paulej72> I am just wondering why there are negitive an positive ones
[13:52:49] <TheMightyBuzzard> oh, no idea.
[13:53:38] <paulej72> in Data.pm there is a strip_subject for the title? is there a reson that is needed vs strip_title?
[13:53:45] <TheMightyBuzzard> there was some reason or other not to use large numbers like 77 but otherwise it was pretty much treated as just a value.
[13:54:56] <TheMightyBuzzard> yep, poorly named but strip_subject is for things like <input value="[% something | strip_subject %]">
[13:55:23] <TheMightyBuzzard> strip subject and strip title should be oppositely named but it'd be a pita to go back and change them all now.
[13:56:00] <paulej72> OK, if you are happy with the names I can live with it
[13:56:21] <TheMightyBuzzard> annoyed with them but too lazy to go back and fix them work?
[13:56:56] <paulej72> does changing the url to https in sthe skins break anything if I am an http users?
[13:57:09] <TheMightyBuzzard> where at?
[13:57:32] <paulej72> swich feeds to https
[13:58:23] <TheMightyBuzzard> nah, it just makes the outgoing links link to https://soylentnews.org instead of http
[13:58:47] <TheMightyBuzzard> unless you can't use https for some reason, should be no issues.
[13:58:55] <paulej72> is it used elsewhere in the code?
[13:59:13] <TheMightyBuzzard> the rss feed itself? only by bender that i know of.
[13:59:35] <paulej72> no in the rest of Slash
[14:01:29] <TheMightyBuzzard> oh, the var. yeah, it's used multiple places and completely broke dev when i typo'd it.
[14:02:11] <TheMightyBuzzard> but dev has been running with it set for over a month and i haven't found an issue yet.
[14:03:36] <paulej72> looks like it causes the site to go full https when you log in and stuff
[14:04:37] <TheMightyBuzzard> possibly, i think that may have been something else doing that though. lemme look at the big PR real quick.
[14:07:06] <TheMightyBuzzard> form action looks like it submits over http if you started out http then gets redirected to https.
[14:07:28] <TheMightyBuzzard> technically a bug but one i can absolutely live with since we're looking to move to https entirely anyway.
[14:08:14] <paulej72> I am going to merge it, but we should have Bytram look for issues :)
[14:08:35] <paulej72> OK all merged.
[14:08:53] <TheMightyBuzzard> cheers. working on moderation rework right now.
[14:09:07] <paulej72> Sorry I did not get to it yesterday, but I was busy all day at work and was dead tired when I got home.
[14:09:34] <TheMightyBuzzard> surprisingly a pita to put a link up to undo spam moderations for anyone with a 100+ seclev.
[14:09:38] <TheMightyBuzzard> no worries
[14:10:54] <TheMightyBuzzard> paulej72, while i have you handy a minute... the new spam moderation... how you feel about -1 to the comment score and -10 to karma for each spam moderation?
[14:11:14] <TheMightyBuzzard> -10 cause spam annoys the piss out of me.
[14:11:15] <paulej72> I would think some of that shit is hard to do. does +100 fall into isAdmin or whatever it is called?
[14:11:33] <TheMightyBuzzard> good question.
[14:12:13] <TheMightyBuzzard> i think anything over 1 technically falls into isAdmin but i'd have to look it up and i want editors and basically anyone but normal users to be able to unflag something as spam.
[14:12:59] <paulej72> while spam is bad, I am not sure if we are really causing a hardship with low karma users any more to warrent the really low karma.
[14:13:25] <TheMightyBuzzard> ya but it does limit how much they can post at the moment. or did we do away with that?
[14:13:41] <paulej72> also if one spam comment is modded spam multiple times, it would karam kill rather quickly.
[14:13:52] <TheMightyBuzzard> yep, that's the general idea
[14:14:16] <TheMightyBuzzard> 50 to the cellar with one HOSTS post
[14:14:23] <paulej72> we still have a limit, but it is not much of a limit, to let peple get out of karma hell easier.
[14:15:32] <TheMightyBuzzard> the editor+ link to unflag spam will undo all the spam moderations and return karma soon as i get it working.
[14:15:51] <paulej72> we could look at lowereing the bottom end and adding a real karma hell to the bottom end. It would take an effort for a spammer to get there, but not hurt a miss spammed mod.
[14:16:35] <TheMightyBuzzard> oh, will also ban everyone whoever modded something spam from getting mod points for the next month
[14:17:34] <TheMightyBuzzard> ideally we should be able to manually review all spam modded comments. could set up a page showing them all.
[14:21:32] <TheMightyBuzzard> general idea is to make spam a mod you really, really do not want applied to you while also making it easy to stop abuses of it.
[14:23:12] <TheMightyBuzzard> also leave an easy trail to follow for legit spams so filters can be built
[14:24:18] <paulej72> there is suff on the admin security pages that would be similar. one of them is a list of all recent posts, but that can easily be changed to just show posts that have been modded spam.
[14:24:51] <TheMightyBuzzard> nod nod. haven't gotten that far but that general area was where i expected to put it
[14:25:28] <TheMightyBuzzard> as well as just throwing a link beside the score on normal comment pages if you're an admin
[14:26:30] <TheMightyBuzzard> both so you don't have to flip back and forth if you're just doing normal comment reading at the moment
[14:29:27] <TheMightyBuzzard> note to self, prevent race condition where out of date admin page could be showing a comment that's already been unspammed from the comment page or by someone else
[21:23:16] -!- Tachyon_ has quit [Quit: De omnibus dubitandum est.]
[21:23:40] -!- Tachyon [Tachyon!Tachyon@hollhb.kolej.mff.cuni.cz] has joined #dev